Comments (2)
Thanks for support!
First we need to determine approach to this feature.
- The one that you described. Pros: backward compatibility, easy to code. Cons: NestJS module philosophy is not supported.
- We create forFeature() method, that declares name, queue, exchange and other parameters. And forRoot() only declare service names, logger and other common features. @RMQRoute gets additional parameter of module name, to bind correctly to the selected module. Pros: logic separation with modules, you can use different connections with different modules. Cons: no backward compatibility (I assume), more hard to implement.
Second approach related to #20
What do you think, would be better and why?
from nestjs-rmq.
I think adding the forFeature()
is a must with or without this change. forFeature()
allows dependency separation which might be quite useful in a modular sort of way, and as you said it, more in line with what NestJS philosophy dictates or is the norm.
However, this FR is not actually a replacement for the nonglobal modules, but rather helps decrease such needs indirectly by adding a new feature that could in the majority of cases used as a workaround. So from the modular point of view, no this feature is not ideal. However, the added functionalities are not going to be provided with the addition of forFeature
anyway, so one can argue that this feature is completely separate.
But yeah, I suppose forFeature
is more preferable. If we write it the way TypeORM does it we might be able to allow backward compatibility. But I have to double-check. I will take a look into this and keep you in the loop for any finding; might even submit a PR for forFeature
. But in any case, if backward compatibility is broken, you can release a new major version, the migration for users would be easy.
from nestjs-rmq.
Related Issues (20)
- Support for amqps protocol HOT 4
- Listen a queue messages, and not queue topics. Its Possible? HOT 2
- Determine serviceName on @RMQRoute HOT 1
- Feature Request: Exclusive Queue HOT 2
- Enhancement: Disable logging for messages HOT 3
- How to handle ERROR_NO_ROUTE? HOT 1
- RabbitMQ URI HOT 3
- Requested service doesn't have RMQRoute with this path HOT 1
- Nestjs 9 HOT 1
- validation + manual ack/nack
- Assert queue programmatically HOT 1
- Error handling broken for 2.8.0 HOT 3
- Update packages please HOT 1
- library goes bootloop when its connected HOT 1
- Update package please HOT 1
- class-validator dependency vulnerability HOT 1
- How i supposed to catch errors thrown from handlers? HOT 2
- Example issue with configService? HOT 2
- Как публиковать в разные exchange и queue?
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from nestjs-rmq.