I've forked and retargeted for multiple frameworks, net45, net 46, and netstandard2.0

[alastairtree]

I've forked and retargeted for multiple frameworks, net45, net 46, and netstandard2.0

[alastairtree]

There is now a beta version of LazyCache 2.0 for netstandard 2 on nuget.org. Feedback most welcome.

dotnet add package LazyCache --version 2.0.0-beta01

In addition there are a set of dependency injection bindings available:

dotnet add package LazyCache.AspNetCore --version 2.0.0-beta01

[matthewacme]

Hello Alastair
Would you still be interested in looking at my netstandard 2.0 implementation fork? I can't submit a pull request, since I'm not a contributor, but I've attached a Zip with my changes.

If you decide to roll this in, please let me know so I can point back to the "Offical" LazyCache nuget package

LazyCache.zip

[johnhamm]

I'll update the feed with the latest buildwhen I get home and see if that changes anything.

[matthewacme]

well color me embarrassed! I was thinking of CachingService's GetOrAdd<T> and just "assumed" MS did the same thing... helps if you RTFM.. thanks for catching that John.

[bradley-varol]

Yes, ASP.NET Core 2.0. Here's a DotNetFiddle of GetRelatedPosts.
This method is to fetch related posts and sort them based on match percentage for a blog API, but i'm not sure how this method would affect LazyCache. It just returns an IEnumerable of related posts.
I'm not confident in my C# code so if you see anything horrific, please let me know lol

[Zeffuro]

I seem to experience the same issue.

https://dotnetfiddle.net/Q6cqxs Code where I try to implement this.
Function: https://dotnetfiddle.net/B0hu7W

[bhedia]

Any movement on this? I would like to take advantage of this package in netstandard2.0 as well.

[alastairtree]

Hi, thanks. I'm away for a couple of weeks bit I will review this on my return and try and pull it in. Thanks!

[johnhamm]

I put up a MyGet Nuget feed with this alpha version until the official version can be released:
https://www.myget.org/F/lazycache/api/v3/index.json

[johnhamm]

@GeekActual:

On line 65 of LazyCache/NetBridgeSpoof.cs, it should set the value of the cache item and return null if an existing value is not found. Otherwise, it won't work with .net standard 2.0:

                public object AddOrGetExisting( string key , object value , CacheItemPolicy policy )
		{
			object result;
			if (this.TryGetValue(key, out result)) {
			     return result;
			}
			else {
			     this.Set(key, value);
			     return null;
			}
		}

[matthewacme]

@johnhamm:
are you sure about that return null? since it is a AddOrGetExisting, think you mean to have it as follows

                public object AddOrGetExisting( string key , object value , CacheItemPolicy policy )
		{
			object result;
			if (this.TryGetValue(key, out result)) {
			     return result;
			}
			else {
			     this.Set(key, value);
			     return value;
			}
		}

[matthewacme]

Damn, didn't mean to close it.

[johnhamm]

Yeah I also think it's odd that AddOrGetExisting returns null when an existing value isn't in the cache, but that's Microsoft's behavior so your NetBridgeSpoof class should as well so there aren't any side effects.

Besides, the CachingService checks to see if it is null when a new value is added, and returns the inserted value if that is the case:
https://github.com/jornj/LazyCache/blob/c1d8b105404b1483983778cffdf67282f560ca5f/LazyCache/CachingService.cs#L105

Microsoft's reference:
https://msdn.microsoft.com/en-us/library/dd988741(v=vs.110).aspx
"If the cache does not have a cache entry whose key matches the key parameter, a new cache entry is created, and the MemoryCache.AddOrGetExisting method overload returns null. If a matching cache entry exists, the existing entry is returned."

[bradley-varol]

Using the alpha package from @johnhamm's feed with .NET Core 2.0 and it appears as though caching isn't working. ObjectCache count isn't increasing and the lambda is being executed every time. Not sure what other information I can give you (relatively new to .net). Any ideas?

ConfigureServices:
services.AddScoped<CachingService>();

Controller:
result.RelatedPosts = _cachingService.GetOrAdd($"relatedPostsForPostId-{postId}", () => _postsRepository.GetRelatedPosts(post, relatedPostsPageLength).ToList());

[matthewacme]

Hey Braed, I assume you are using .Net Core 2.0 (ASP.NET Core 2.0)? Can you offer a copy of the code that doesn’t appear to be working? What does the GetRelatedPosts code look like? Matthew

[Zeffuro]

Please let us know when you did, would love to try it out!

[johnhamm]

OK I've created a fork and fixed the .NET core issues. You can find the myget link here:

https://github.com/johnhamm/LazyCache

[Zeffuro]

Updated but still it's not caching: https://i.imgur.com/CxJrObB.png

[johnhamm]

All the unit tests passed. When I create a simple app.net core app, it caches. Can you upload a project?

[Zeffuro]

I just uploaded my project to github (was a bit lazy before not uploading it yet :D)
Here's the file that should do the caching.

https://github.com/Jeffroiscool/AnimeFlix/blob/master/AnimeFlix/Pages/Anime.cshtml.cs

[johnhamm]

I am getting a cache entry when I try it on your project:
https://imgur.com/a/snSIm

[Zeffuro]

Strange, what did you change? Did you actually try it in the page model?

[Zeffuro]

Sorry for the lack of feedback, I had a smarter friend look for me and he made this commit to my program to get it working: Zeffuro/AnimeFlix@5bf02f7

And that's with using this version of Lazycache: https://www.myget.org/F/lazycache/api/v3/index.json

[alastairtree]

I have started work on dotnet core, but have taken a slightly different approach to that of this fork. The basics are now working. I decided to target netstandard 2 (and not do multi targeting) and there are a number of breaking changes so this will be a major bump to version 2.0. Feel free to check out https://github.com/alastairtree/LazyCache/tree/feat/netcore2 if you are keen. Any feedback is welcome, and let me know if you think the breaking changes are unreasonable - I hope they should be very quick to fix.
If you are really keen the latests nupkg is available at https://ci.appveyor.com/project/alastairtree/lazycache/build/artifacts but I think it still needs some work so not a proper release yet.

[alastairtree]

I expect to release version 2 soon (already out in pre release) and as no-one is shouting for a multi targeted net45/46 version I feel I can close this issue for the alternative fork. Please shout if you disagree.