Giter Site home page Giter Site logo

Comments (4)

no-more avatar no-more commented on June 18, 2024 9

Hi,

I think it would be great to make this works with reactive forms without having to handle the change event and mark the form as dirty manually.

BTW, thanks a lot for this tool.

from angular2-color-picker.

hvqthong avatar hvqthong commented on June 18, 2024 2

+1

from angular2-color-picker.

BrainCrumbz avatar BrainCrumbz commented on June 18, 2024 1

Nevermind, it seems we found a way (that requires changes to this library as well). For future readers:

<!-- ... -->
  <form class="container" [formGroup]="myForm">
      <label for="myField">Some label</label>
      <input id="myField" formControlName="myControl" type="text"
                  [colorPicker]="currentColor"
                  (colorPickerChange)="onColorPickerChange($event)">
  </form>
<!-- ... -->

Basically, two-way binding on color picker is split into its two sides:

  • one-way binding works by detecting changes on currentColor and communicate updates from model to color picker.
  • updates from color picker (strictly speaking, only when color is picked or typed) are sent to model through onColorPickerChange event handler
export class MyComponent implements OnInit {
  myForm: FormGroup;
  myControl: FormControl;

  constructor(private fb: FormBuilder) {
  }

  ngOnInit() {
    this.myForm = this.fb.group({
      myControl: ['', Validators.required],
    });
    this.myControl = this.myForm.controls['myControl'];

    this.myForm.valueChanges.subscribe(/* ... */);
  }

  someSetterMethod(newValue: string) {
    this.myForm.patchValue({
      myControl: newValue,
    });
  }

  get currentColor(): string {
    return (
      this.myForm&&
      this.myForm.controls &&
      this.myForm.controls['myControl'] &&
      this.myForm.controls['myControl'].value ||
      null);
  }

  onColorPickerChange(colorCode: string): void {
    this.myControl.setValue(colorCode);
    this.myControl.markAsDirty();
    this.myControl.markAsTouched();
  }
  // ...
}

When model is updated through someSetterMethod(), form values change, hence control value changes, hence currentColor changes and color picker "sees" the update.

When a color is picked, onColorPickerChange() is invoked, control value is updated accordingly.

In order to avoid change detection exceptions in dev mode, all EventEmitter instances within color picker library had to be created differently:

// from:
//new EventEmitter<SomeType>();

// to
new EventEmitter<SomeType>(true);

This is after a breaking change introduced after RC2 or later, where emitters default sync/async behaviour changed. Now true forces emitter to revert back to previous default behaviour, async.

from angular2-color-picker.

Alberplz avatar Alberplz commented on June 18, 2024 1

Hi
I should documented that...I've added a new example using the output event
Thanks

from angular2-color-picker.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.