Comments (4)
Hi,
I think it would be great to make this works with reactive forms without having to handle the change event and mark the form as dirty manually.
BTW, thanks a lot for this tool.
from angular2-color-picker.
+1
from angular2-color-picker.
Nevermind, it seems we found a way (that requires changes to this library as well). For future readers:
<!-- ... -->
<form class="container" [formGroup]="myForm">
<label for="myField">Some label</label>
<input id="myField" formControlName="myControl" type="text"
[colorPicker]="currentColor"
(colorPickerChange)="onColorPickerChange($event)">
</form>
<!-- ... -->
Basically, two-way binding on color picker is split into its two sides:
- one-way binding works by detecting changes on currentColor and communicate updates from model to color picker.
- updates from color picker (strictly speaking, only when color is picked or typed) are sent to model through onColorPickerChange event handler
export class MyComponent implements OnInit {
myForm: FormGroup;
myControl: FormControl;
constructor(private fb: FormBuilder) {
}
ngOnInit() {
this.myForm = this.fb.group({
myControl: ['', Validators.required],
});
this.myControl = this.myForm.controls['myControl'];
this.myForm.valueChanges.subscribe(/* ... */);
}
someSetterMethod(newValue: string) {
this.myForm.patchValue({
myControl: newValue,
});
}
get currentColor(): string {
return (
this.myForm&&
this.myForm.controls &&
this.myForm.controls['myControl'] &&
this.myForm.controls['myControl'].value ||
null);
}
onColorPickerChange(colorCode: string): void {
this.myControl.setValue(colorCode);
this.myControl.markAsDirty();
this.myControl.markAsTouched();
}
// ...
}
When model is updated through someSetterMethod(), form values change, hence control value changes, hence currentColor changes and color picker "sees" the update.
When a color is picked, onColorPickerChange() is invoked, control value is updated accordingly.
In order to avoid change detection exceptions in dev mode, all EventEmitter instances within color picker library had to be created differently:
// from:
//new EventEmitter<SomeType>();
// to
new EventEmitter<SomeType>(true);
This is after a breaking change introduced after RC2 or later, where emitters default sync/async behaviour changed. Now true
forces emitter to revert back to previous default behaviour, async.
from angular2-color-picker.
Hi
I should documented that...I've added a new example using the output event
Thanks
from angular2-color-picker.
Related Issues (20)
- Can't bind to 'colorPicker' since it isn't a known property of 'input' HOT 19
- IE10 - Colorpicker not closing HOT 1
- Using the 'top' position causes weird functionality HOT 3
- Positioning seems to be broken if the input field is inside a modal
- Dialog height only being set once. HOT 2
- System.config.js can't find ionic 3 angular 2
- Issue when loading ColorPickerModule in App Module HOT 10
- Is there any event binded to ok button click ? HOT 2
- error in build --proad --aot mode
- App Stops loading after adding colorPicker
- Can compile in Aot mode
- cpType is undefined HOT 1
- Angular5 issue HOT 1
- Cannot read property 'a' of undefined HOT 3
- Getting Error for ng build--aot HOT 4
- Angular Application is taking more than 20 seconds to load application
- Error in npm istall HOT 1
- ERROR in node_modules/angular2-color-picker/node_modules/rxjs/Subject.d.ts(24,5): HOT 3
- cpDialogDisplay=inline with a custom cpWidth leads to unusable hue slider
- Cancel button works in Firefox but not in Google Chrome
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from angular2-color-picker.