Comments (9)
Hi,
I think I have the same issue, change event is triggered when my components init, and so I mark my form as dirty by error. It would be great to not trigger the event on input changes or at least not on creation.
Thanks
from angular2-color-picker.
@Alberplz a new option isn't needed. I did this and that works perfectly!
ngOnInit() {
var hsva = this.service.stringToHsva(this.colorPicker);
if (hsva == null) {
hsva = this.service.stringToHsva(this.cpFallbackColor);
}
if (this.created) {
this.colorPickerChange.emit(this.service.outputFormat(hsva, this.cpOutputFormat));
}
}
FYI: it's better to use let
than var
in typescript.
from angular2-color-picker.
@renaudaste angular2-color-picker is not maintained anymore. Use this instead: https://github.com/zefoy/ngx-color-picker
It is a drop in replacement for this package and should work out of the box with bug fixes and added features. Should your use case not be covered yet in it, feel free to report it there.
from angular2-color-picker.
If the event is only fired when the color input format doesn't match with the color output format?
I can change that line by:
let output = this.service.outputFormat(hsva, this.cpOutputFormat);
if (output !== this.colorPicker) {
this.colorPickerChange.emit(this.service.outputFormat(hsva, this.cpOutputFormat));
}
from angular2-color-picker.
@Alberplz that's a solution for components that are dynamically created, but if you use the renderer
to alter some stuff on dynamic created components, then it will still use the values created by color picker instead of the pre-set colors.
from angular2-color-picker.
Then a new option to control that line could be a good solution
from angular2-color-picker.
I have not tested with components dynamically created but it's nice!! :)
Yes....yesterday I committed that var
from angular2-color-picker.
any update on this? Thank you
from angular2-color-picker.
Any update on this feature ? (would be great not to have to fork).
Current code on master is still : https://github.com/Alberplz/angular2-color-picker/blob/master/src/color-picker.directive.ts#L64-L71
Thank you for your great work 👍
from angular2-color-picker.
Related Issues (20)
- Can't bind to 'colorPicker' since it isn't a known property of 'input' HOT 19
- IE10 - Colorpicker not closing HOT 1
- Using the 'top' position causes weird functionality HOT 3
- Positioning seems to be broken if the input field is inside a modal
- Dialog height only being set once. HOT 2
- System.config.js can't find ionic 3 angular 2
- Issue when loading ColorPickerModule in App Module HOT 10
- Is there any event binded to ok button click ? HOT 2
- error in build --proad --aot mode
- App Stops loading after adding colorPicker
- Can compile in Aot mode
- cpType is undefined HOT 1
- Angular5 issue HOT 1
- Cannot read property 'a' of undefined HOT 3
- Getting Error for ng build--aot HOT 4
- Angular Application is taking more than 20 seconds to load application
- Error in npm istall HOT 1
- ERROR in node_modules/angular2-color-picker/node_modules/rxjs/Subject.d.ts(24,5): HOT 3
- cpDialogDisplay=inline with a custom cpWidth leads to unusable hue slider
- Cancel button works in Firefox but not in Google Chrome
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from angular2-color-picker.