Giter Site home page Giter Site logo

Comments (14)

aldenml avatar aldenml commented on August 19, 2024 3

With #198 I released 2.0.4-22-RC1, already in maven, please, give it a try.

from libtorrent4j.

aldenml avatar aldenml commented on August 19, 2024 2

Hi @proninyaroslav, I think we are close to a deadline or something regarding this new restriction. I tried to fix it the past weekend but I'm not there yet. What's your position on dropping support for API < 24?

from libtorrent4j.

anantadwi13 avatar anantadwi13 commented on August 19, 2024 1

It's ok. Thank you for your response.

from libtorrent4j.

qyzhaojinxi avatar qyzhaojinxi commented on August 19, 2024 1

I met this problem too. I'm looking forward to a quick resolution.

from libtorrent4j.

anantadwi13 avatar anantadwi13 commented on August 19, 2024 1

With #198 I released 2.0.4-22-RC1, already in maven, please, give it a try.

LGTM. It's running well using API 31 on Android 8.1 and Android 11 real devices. Thank you for your hard work! @aldenml @gubatron

from libtorrent4j.

aldenml avatar aldenml commented on August 19, 2024

Hi @anantadwi13 , thanks for the report, I'm aware of the issue and I have plans to fix it soon, unfortunately, I can't give you an ETA.

from libtorrent4j.

aldenml avatar aldenml commented on August 19, 2024

@gubatron I tried to apply the patch that you posted in arvidn/libtorrent#6251 (comment), but for some reason, DHT seems to not work. Does this sound familiar?

from libtorrent4j.

gubatron avatar gubatron commented on August 19, 2024

@aldenml did you also update the SDK versions of the toolchains to be api 24?

RUN cd /src \
    && android-ndk/build/tools/make_standalone_toolchain.py --arch arm --api 24 --stl libc++ --install-dir android-toolchain-arm \
    && android-ndk/build/tools/make_standalone_toolchain.py --arch arm64 --api 24 --stl libc++ --install-dir android-toolchain-arm64 \
    && android-ndk/build/tools/make_standalone_toolchain.py --arch x86 --api 24 --stl libc++ --install-dir android-toolchain-x86 \
    && android-ndk/build/tools/make_standalone_toolchain.py --arch x86_64 --api 24 --stl libc++ --install-dir android-toolchain-x86_64

also, there were a bunch of sed replacements that I got rid of for those API numbers as I upgraded to API 24.

Other than that no issues for me connecting to DHT.

I'm still having a nasty crash on arm32 bit on a real device that AT&T started giving out for free to people (I believe it runs Android 10 or 11), been trying to fix it for weeks now, having trouble to get a debugger on Android SDK to let me step down to C++, I've decided I will release as is and hopefully upload the symbol's file for arm32 to have some light of why it's crashing, this is the only instance where I can't get DHT to work because nothing works.

from libtorrent4j.

proninyaroslav avatar proninyaroslav commented on August 19, 2024

@aldenml
I get this on some real devices, although I can't reproduce it on an emulator:

LISTEN_FAILED - listen_failed - listening on 0.0.0.0:0 (device: ) failed: [enum_if] [TCP] Permission denied

In particular, this problem occurs when fetching magnets.

from libtorrent4j.

proninyaroslav avatar proninyaroslav commented on August 19, 2024

@aldenml
Thank you for your work. I looked at Google Play statistics for LibreTorrent and the number of active installations with API 21-23 is about 2.4% of the total number of installations (and 3% of all installations/uninstallations). This doesn't take into account installs from third-party sources and F-Droid (there will probably be more). This seems like a small number, but this is 2000-3000 people who will be left without support. I've always found it difficult to take such a step, so I'll leave it up to you. If API <24 support is burdensome or impossible, then you are free to up the API version. Let me know if you make such a decision.

from libtorrent4j.

gubatron avatar gubatron commented on August 19, 2024

from what I'm seeing here at jlibtorrent we had to make that decision. API 23 and under is at least 4 years old, plenty of time to upgrade for most people, and those that can't afford an update can still use older clients which will work decently as they have up to now given the stability of libtorrent.

from libtorrent4j.

aldenml avatar aldenml commented on August 19, 2024

@proninyaroslav thank you very much for sharing the information. I will make the hard decision and go ahead removing support for API < 24.

from libtorrent4j.

proninyaroslav avatar proninyaroslav commented on August 19, 2024

This seems to be fixed, I haven't encountered this error.

from libtorrent4j.

aldenml avatar aldenml commented on August 19, 2024

@proninyaroslav thanks for reporting back.

from libtorrent4j.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.