libtorrent doesn't call remove() in POSIX wrapper

[proninyaroslav]

libtorrent doesn't call remove() in POSIX wrapper

[aldenml]

Hi @proninyaroslav, still nothing, but this is on my list

[aldenml]

@proninyaroslav thank you very much for this information, it is really helpful. I will not be able to work in this for a few more days.

[aldenml]

sounds like a bug to me, maybe there was a change in the libtorrent source code that I didn't take into account

[proninyaroslav]

Do you have any news? This issue is quite important compared to other POSIX wrapper problems, without this I can’t make a new release of the app :(

[proninyaroslav]

1.2.2.0 still has this problem.

[proninyaroslav]

I made strace and noticed that libtorrent doesn't use the remove() system call, but unlinkat() to delete the file. Therefore, I can't catch file removing in posix_wrapper (Android 10):

unlinkat(AT_FDCWD, "/saf_root(com.android.externalstorage.documents/tree/1018-230F%3A);/CCleaner Professional Plus v5.25.0.5902 x86-x64 Setup + CRACK.7z", 0) = -1 ENOENT (No such file or directory)
unlinkat(AT_FDCWD, "/saf_root(com.android.externalstorage.documents/tree/1018-230F%3A);/.26e8d03aff486d164e262d0a09cadbe8fc4f71a9.parts", 0) = -1 ENOENT (No such file or directory)

[proninyaroslav]

@aldenml I think you need to add this call to posix_wrapper.

[proninyaroslav]

On Android 6.0, I have a different situation:

fstatat64(AT_FDCWD, "/saf_root(com.android.externalstorage.documents/tree/10F4-1006%3A);/F-Secure Freedome VPN 2.32.6293 RePack by elchupacabra/", 0x8f7fb458, AT_SYMLINK_NOFOLLOW) = -1 ENOENT (No such file or directory)

Instead of unlinkat() calls, I have many fstatat64() calls, which, of course, are unsuccessful.

[proninyaroslav]

@aldenml Thank you. If you need other information or strace's from other Android versions, let me know.

[aldenml]

@proninyaroslav which version of libtorrent4j are you using for this strace?

[proninyaroslav]

@aldenml 1.2.3.0

[aldenml]

that's strange, I don't use the weak symbols hack in this version, it should be something else

[proninyaroslav]

That’s all I could see useful in strace. The only fact is that the POSIX wrapper remove() method is not called.

[proninyaroslav]

Fixed in 1.3.0-alpha-5