Improve documentation for Dispatch() and FullCommand()

[alecthomas]

Improve documentation for Dispatch() and FullCommand()

[alecthomas]

There is already a .Dispatch() hook on flags and commands. Is this sufficient?

eg.

cmd := app.Command("greet", "Greet a user").Dispatch(func(*ParseContext) error {
  println("hi")
})

Also, you don't need to duplicate string constants. Just use cmd.FullCommand() in the case statements.

[fluffysquirrels]

Dispatch looks good. On glancing at the code the ParseContext parameter type made me think it was for dispatching parsing, not running the commands themselves. I'd like to add documentation to this.

I'd missed cmd.FullCommand(), yes that would help things. I see it's used in README.md but missing in the godoc example. I'd like to update the godoc example as well.

Those two are a big improvement, thanks for pointing them out.

This still doesn't get rid of the switch statement, which I think would be a big improvement. Would you be interested in a PR to add the documentation I mentioned above and dispatch automagically to your commands' Dispatch handlers?

[alecthomas]

More documentation is always better!

Dispatch() is called after a command is parsed, so you shouldn't need a switch statement AFAICT. Unless I'm missing something?

[fluffysquirrels]

I'm so sorry for wasting your time on this. I was scanning the code by using the Github search tool with the keyword dispatch, which it turns out only shows a few matches per file. That'll teach me for not using grep! Looking again I can see the unit test to verify cmd.Dispatch() is called.

I'll submit a PR to update some of the documentation, which will hopefully make these best practices more discoverable.

[alecthomas]

No problem! As you say, documentation is a bit lacking :)