Toggle Editing Mode

[alefragnani]

Toggle Editing Mode

[muellerkyle]

Thanks Alessandro. I appreciate the consideration!

…

On Jan 16, 2018, at 6:08 PM, Alessandro Fragnani ***@***.***> wrote: Hi @muellerkyle , If probably happened caused by a VS Code API change, reverting the preview default value, because when I updated the code, I'm pretty sure it worked just fine. I even commented that 😄 . Anyway, I will take at your PR and see how it goes. If everything is fine, I will push an update next weekend. Hope this helps — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

[alefragnani]

Hi @muellerkyle ,

I get it 👍 I don't know if there is an API for that, but I will take a look. If yes, I could add a config for that.

[alefragnani]

Depends on microsoft/vscode#10568

[muellerkyle]

Somehow I missed responding to your update. Apologies for that!

I see the ticket that you opened with vscode. It may be of interest to note that I originally logged this as a requested feature with the vscode team and was directed to see if I could get you to implement it.

This seems to be stuck in a loop. See Tyriar's response below mine.

See: microsoft/vscode#224 (comment)

[alefragnani]

Hi @muellerkyle, no problem about that 👍

I understand you concern, but I don't see a loop here. My issue to force a document to be pinned is still open.

Tyriar's suggested to you to open an issue here because, since this extension is not a core extension, he could not be responsible to update the extension (unless of course via PR, which would be wellcome 😄 ). But in fact, the issue is a bit different. We don't want to make openned files to be automatically pinned, but in fact, pin an already openned document.

So, we still have to wait. Unfortunatelly there is no milestone assigned.

Maybe you could turn off preview tabs ("workbench.editor.enablePreview": false) in the meantime.

[muellerkyle]

Hi alefragnani,

There seems to have been some progress on this item on the VS Code repo.

Any chance that you could add this after the next drop from their side?

Thank you!

[alefragnani]

Hi @muellerkyle , that's the idea 😄

[muellerkyle]

Thanks @alefragnani !

[muellerkyle]

Hi alefragnani,

I have come back around to VS Code and noticed that you got this fix in, but issue # 74 seems to have broken the fix.

I checked the API for VS Code and I think that there is a workable compromise that keeps the fix for issue #74 in tact.

I've cloned your repo and will put in a pull request so that you can see the change.

Thank you!

[alefragnani]

Hi @muellerkyle ,

If probably happened caused by a VS Code API change, reverting the preview default value, because when I updated the code, I'm pretty sure it worked just fine. I even commented that 😄 .

Anyway, I will take at your PR and see how it goes. If everything is fine, I will push an update next weekend.

Hope this helps