Custom Multiple Output ports are not working

[alelievr]

Custom Multiple Output ports are not working

[merpheus-dev]

Update: I believe I might have a solution, I've debugged further and found that in BaseGraphView.cs:

if (serializeToGraph)
{
				NodePort inputPort = inputNodeView.nodeTarget.inputPorts.FirstOrDefault(o => o.portData.identifier == inputPortView.portData.identifier);
				NodePort outputPort = outputNodeView.nodeTarget.outputPorts.FirstOrDefault(o => o.portData== outputPortView.portData);

				e.userData = graph.Connect(inputPort, outputPort);
}

This line is
NodePort outputPort = outputNodeView.nodeTarget.outputPorts.FirstOrDefault(o => o.portData== outputPortView.portData); causing that issue. So I've changed it to o.portData.identifier== outputPortView.portData.identifier. And now it seems to be working for output ports.

Do you see any setbacks or side effects that it will cause ? If not, I'll send a PR.

[alelievr]

Hi, indeed there is an error in the code that finds the output port, it must use the identifier to find the port. I did a fixed in master for this: 33901bf where i use GetPort instead of iterating over all ports manually.

Thanks for reporting the issue and taking the time to investigate :)

[merpheus-dev]

Thank you for your interest as well :) Good solution, I'll pull and see how it goes. For know I am closing the issue, if something like that occurs I'll open it back up. Cheers!