Comments (9)
Thanks for the feedback. I will bring it up with the team!
from alexa-skills-kit-sdk-for-java.
Actually proxy was working perfectly using standard java properties (http.proxyHost, http.proxyPort [...]). Now it is broken and there is no documentation about how to configure proxy using your custom Proxy mechanism. I would strongly suggest to rollback this change and stick to standard Java proxy environment settings.
from alexa-skills-kit-sdk-for-java.
Hey Johann, thanks for reporting this. I did not realize that the original change would have the side affect of explicitly overriding a user's proxy settings if they were providing them via environment variables. PR #142 restores the original behavior and should fix this issue, while at the same time retaining the ability to explicitly provide a proxy to be used by the servlet if so desired.
from alexa-skills-kit-sdk-for-java.
Hi Jonathan. Thanks for the quick update ! Do you know when this change will be released in the sdk ? It is currently blocking our customer demos, just to know if I should patch my code for now, or if I just wait for a new release to be done.
from alexa-skills-kit-sdk-for-java.
2.5.4 is out now and contains this fix. :)
from alexa-skills-kit-sdk-for-java.
Awesome !
from alexa-skills-kit-sdk-for-java.
Well, one more issue with this : Out of the box, the proxy is still forced to NO_PROXY in SkillServlet here
I really think the default behavior should comply with Java conventions for proxy (i.e. using standard env variables)
from alexa-skills-kit-sdk-for-java.
Yep, you are totally correct. That's a miss on my end with the change. I'll make sure a follow up change gets pushed out shortly.
from alexa-skills-kit-sdk-for-java.
Hey Johann, 2.5.5 contains the follow-up fix for this. Let me know if you have any other issues.
from alexa-skills-kit-sdk-for-java.
Related Issues (20)
- “NoSuchMethodErrors” due to multiple versions of com.fasterxml.jackson.core:jackson-core:jar HOT 6
- com.amazon.ask.exception.AskSdkException: Could not find a skill to handle the incoming request HOT 2
- Accept Grant handler HOT 1
- Jackson cannot deserialze errors HOT 4
- Delegate directives from LaunchRequest should be able to come back to the skill as IntentRequests HOT 3
- Alwxa HOT 1
- maven artifacts for ASK SDK for Java should not depend on an SLF4J binding, but only the API
- Hello World Servlet - There was a problem with the requested skill's response HOT 2
- ServiceClientFactory in SMAPI SDK clashes with core one HOT 2
- Release notes for 2.38.0 missing HOT 1
- Conflicting persistence adapter configuration HOT 1
- Dependency org.apache.httpcomponents:httpclient, leading to CVE problem HOT 1
- Releases are outdated HOT 1
- Missing CI on PRs HOT 2
- Feature: support SHA256withRSA algorithm for signature HOT 1
- Missing withExperimentation method in ResponseBuilder for ask-sdk-core 2.42.3 HOT 1
- Deserialization of non-published Requests fails
- CVE-2022-31159 vulnerable
- missing assertions on unit tests
- migrate from Java EE to Jakarta EE HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from alexa-skills-kit-sdk-for-java.