Remove if condition in _run_handlers

[alexander-akhmetov]

Remove if condition in _run_handlers

[sekarpdkt]

Ok. Thanks for suggestion. Will do it this weekend and let u know.

[alexander-akhmetov]

Hi,

or we can create another method for add_message_handler like add_call_handlerand append functions to new list like _call_handler. In else condition use it.

It would be nice to have this! Maybe it's better to name this method like add_update_handler and not to call it in the else condition, but every time for every update (there is already an _update_handlers list for that):

   
    def add_update_handler(self, func: Callable):
       # later here we can add a second parameter: type
       # to register handlers for specific types
        if func not in self._update_handlers:
            self._message_handlers.append(func)

    def _run_handlers(self, update: Dict[Any, Any]) -> None:
        if update.get('@type') == 'updateNewMessage':
            for handler in self._message_handlers:
                self._workers_queue.put(
                    (handler, update),
                    timeout=self._queue_put_timeout,
                )
        
        for handler in self._update_handlers:
                self._workers_queue.put(
                    (handler, update),
                    timeout=self._queue_put_timeout,
                )

If you have time, you can create a PR, if not, I will assign this issue to myself. :)

[sekarpdkt]

I did this way. If ok, will send a PR

self._update_handlers: List[Callable] = {}

I declared it as a dictionary. Then

    def _run_handlers(self, update: Dict[Any, Any]) -> None:
        if update.get('@type') == 'updateNewMessage':
            for handler in self._message_handlers:
                self._workers_queue.put(
                    (handler, update),
                    timeout=self._queue_put_timeout,
                )
        try:
            for handler in self._update_handlers[update.get('@type')]:
                    self._workers_queue.put(
                        (handler, update),
                        timeout=self._queue_put_timeout,
                    )
                    print(update.get('@type'))

        except KeyError:
            pass;
        
    
   
    def add_update_handler(self, updateType,func: Callable):
        try:
            if func not in self._update_handlers[updateType]:
                self._update_handlers[updateType].append(func)
        except KeyError:
            self._update_handlers[updateType]=[]
            self._update_handlers[updateType].append(func)
            
    def add_message_handler(self, func: Callable) -> None:
        if func not in self._message_handlers:
            self._message_handlers.append(func)

[alexander-akhmetov]

👍 Overall it looks nice, exactly what I meant in the comment # later here we can add a second parameter: type to register handlers for specific types.

I would try to avoid big try-except block in the _run_handlers method and used self._update_handlers.get(update_type, []) instead. And I think add_message_handler can add functions to the _update_handlers with a relevant type.

[sekarpdkt]

Ok.. got the point. As add update will be called only once, it should be ok. Where as run handlers will handle all calls, keeping it light weight is what you mean, I think.

    def _run_handlers(self, update: Dict[Any, Any]) -> None:

        for handler in self._update_handlers.get(update.get('@type'),[]):
                self._workers_queue.put(
                    (handler, update),
                    timeout=self._queue_put_timeout,
                )

    def add_update_handler(self, updateType,func: Callable):
        try:
            if func not in self._update_handlers[updateType]:
                self._update_handlers[updateType].append(func)
        except KeyError:
            self._update_handlers[updateType]=[]
            self._update_handlers[updateType].append(func)
            
    def add_message_handler(self, func: Callable) -> None:
        self.add_update_handler('updateNewMessage',func);
            

[alexander-akhmetov]

Yes, exactly :) Also, change updateType to type, please :) (Maybe it will be more convenient to continue in the PR)

[alexander-akhmetov]

Fixed in #19