Comments (6)
Contributor
It was just merge jank.
from waybar.
How did #3299 do any of that? It didn't change the actual logic of anything...it encapsulated and sorted things..
from waybar.
How did #3299 do any of that? It didn't change the actual logic of anything...it encapsulated and sorted things..
The whole button.show() and buttin.hide() logic is missing, there's only button.show_all() call in the entirety of workspaces.cpp
, and there's not a single call to activeOnly()
.
You can also verify that "active-only" doesn't work by adding "active-only": true,
to your config.json.
A part of the logic has been lost somewhere in the refactor.
from waybar.
How did #3299 do any of that? It didn't change the actual logic of anything...it encapsulated and sorted things..
The whole button.show() and buttin.hide() logic is missing, there's only button.show_all() call in the entirety of
workspaces.cpp
, and there's not a single call toactiveOnly()
.
Stuff that was in the Workspace:: context was separated from Workspaces.cpp... activeOnly was a workspace concept based on the code and is in use in the same locations, still but a different file... The workspace.hpp declares m_workspacesManager to interact with Workspaces and check the activeOnly() in that same update method, as before. It also has the button hide and show in that method.
You can also verify that "active-only" doesn't work by adding
"active-only": true,
to your config.json.A part of the logic has been lost somewhere in the refactor.
I will disable my persistent workspaces and see if i can replicate without them...
from waybar.
You can also verify that "active-only" doesn't work by adding
"active-only": true,
to your config.json.
A part of the logic has been lost somewhere in the refactor.I will disable my persistent workspaces and see if i can replicate without them...
from waybar.
@zjeffer @Syndelis I guess I'm curious if you're seeing the same behavior. From looking at the code and self testing, it works with my nix build of the application...
from waybar.
Related Issues (20)
- Multiple waybars open after resume from dpms off. HOT 4
- Dots showing up for some modules HOT 1
- Regression in clock module formatting HOT 4
- Images loaded with image module look blury
- Electron application will shake if mouse hover at workspace
- Sink not matching default if app launched with different sink as default HOT 1
- The battery level always falls back to BAT0 capacity regardless of exec command
- Weather widget wont open unless I manually run it waybar HOT 3
- Waybar crashes on voidlinux with hyprland (builded from src template)
- Tooltip Issue When Waybar is Positioned at Bottom HOT 10
- [Bug]: Waybar No Icons and Date Tooltip not Centered;Hyprland v0.41.0 HOT 3
- wlr/taskbar HOT 8
- `backlight/slider` module sets brightness to `min` value after dpms
- Glyphs and Fonts HOT 1
- support tooltip for systemd-failed-units
- Waybar crash after hyprctl dpms off/on HOT 1
- wlr/taskbar on multi-monitor: icons not displayed for apps launched before waybar
- Cannot update HOT 4
- hyprland/workspaces no longer display persistent workspaces HOT 1
- Sway workspace option "current-only" is empty when a window is active HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from waybar.