Adding Hidden "." Directories

[alexcrichton]

Adding Hidden "." Directories

[alexcrichton]

Oh it may be invalid not allowing a . entry, that validation logic should allow a path like that. Wanna send a PR to update that piece?

[mmstick]

A pull request for Rust or for this crate?

[alexcrichton]

ah presumably for this crate, I suspect the bug is not with the standard library

[mmstick]

I see that an "." Path is interpreted as Component::CurDir which matches to continue without setting emitted to true which triggers the error.

[mmstick]

After changing continue to {}, I am now able to create the hidden directory.

[alexcrichton]

Ah yeah that was meant to encode paths like foo/./bar as foo/bar, but if there's only one CurDir that should perhaps be treated specially

[mmstick]

Added a check to see if there is only one instance of CurDir with

let cur_dir_is_path = path.components().filter(|x| x == &Component::CurDir).count() == 1;

And then added a separate match test

Component::CurDir if cur_dir_is_path => {},

This continues to work without causing an error.

[opilar]

I make a little test and it passed:

let td = t!(TempDir::new("tar-rs"));
let mut ar = Builder::new(Vec::new());
let tmppath = td.path().join("tmpfile");
t!(t!(File::create(&tmppath)).write_all(b"c"));
t!(ar.append_dir(".", "."));
t!(ar.append_file("./a", &mut t!(File::open(&tmppath))));
t!(ar.finish());

[mmstick]

This was implemented a while ago, so I'll close this.