how to set default value for redirectTo

[khodabandelu]

how to set default value for redirectTo

[AlexKhymenko]

@timhoekstra @khodabandelu After careful thinking its much better to add Your code to the documentation so it will be easier for people to create their own custom guard.It will solve more problems. Thank You for helping!

[AlexKhymenko]

@timhoekstra This is great idea. Will look into it

[khodabandelu]

i need default value for all canload and canActivate to redirect to page 403 so that I dont have to duplicate redirecTo option to set route 403 for permission exception whereever i use NgxPermissionGuard .

for solve this problem i have to create own permmissionGuard and override NgxPermissionsRouterData before call NgxPermissionGuard methods.

my own Guard that I use NgxPermissionsGuard methods to support this feature.

@Injectable({providedIn: 'root'})
export class PermissionsGuard implements CanActivate {

	constructor(private ngxPermissionsGuard: NgxPermissionsGuard, private authService: AuthService) {
	}

	canActivate(route: ActivatedRouteSnapshot, state: RouterStateSnapshot): Promise<boolean> | boolean {
		if (route && route.data && route.data.permissions as NgxPermissionsRouterData && route.data.permissions.redirectTo == undefined) {
			route.data.permissions.redirectTo = '/error/error-403';
		}
		if (!this.checkAuth()) {
			return false
		} else {
			return this.ngxPermissionsGuard.canActivate(route, state);
		}
	}

	canLoad(route: Route): boolean | Observable<boolean> | Promise<boolean> {
		if (route && route.data && route.data.permissions as NgxPermissionsRouterData && route.data.permissions.redirectTo == undefined) {
			route.data.permissions.redirectTo = '/error/error-403';
		}
		if (!this.checkAuth()) {
			return false
		} else {
			return this.ngxPermissionsGuard.canLoad(route);
		}
	}


	checkAuth() {
		const currentUser = this.authService.currentUserValue;
		if (currentUser) {
			// logged in so return true
			return true;
		}

		// not logged in so redirect to login page with the return url
		this.authService.logout();
		return false;
	}

}

[timhoekstra]

This is use case when in the project You just want to block user coming to page, not to redirect him somewhere

Do you mean having to specify it on every route as empty?

I would expect the following:

defaultRedirectTo specified, no redirectTo on route -> defaultRedirectTo triggers
defaultRedirectTo specified, redirectTo on route -> redirectTo on route triggers

If you want to keep the option open to block the incoming user then yes I think it's a good idea to be able to specify an empty object to block the user either as the defaultRedirectTo or the route redirectTo.

I would like to remark that in the meantime I have also taken the approach of @khodabandelu and created a new guard that forwards the canActivate etc. calls to NgxPermissionsGuard and put some default behavior in there. That also solves the problem.

[timhoekstra]

I will try to expand a bit on this question and add the necessary information for the feature request according to the new issue guidelines since I have it as well.

I'm submitting a...

[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report  
[x ] Feature request
[ ] Documentation issue or request

Current behavior

What I'm looking for is a way to configure a default behavior for when the permissions get rejected to handle the permission rejection and in my use-case redirect to a specific route.
What I could currently find is that there is the redirectTo property that can be configured in the routing configuration (https://github.com/AlexKhymenko/ngx-permissions#multiple-redirection-rules).
To achieve the same default behavior for all routes that have permissions defined then this would mean having to have a central function that I provide on each route that gets defined.
Kind of like is documented.

export function defaultRedirectTo(rejectedPermissionName: string, activateRouteSnapshot: ActivatedRouteSnapshot, routeStateSnapshot: RouterStateSnapshot) => {                                                 
    return 'login';
}

permissions: {
	redirectTo: {
		path: defaultRedirectTo
	}
}

However it's easy to forget to define this in some places which leads to a difference in behavior in the application. This is something I would like to prevent and I would like the default behavior to be predictable by default.

Expected behavior

I was thinking a good place for it would be a default redirectTo on the NgxPermissionsModule.forRoot which gets overriden by redirectTo on the specific route permissions?

NgxPermissionsModule.forRoot({
	defaultRedirectTo: myFunction
})

This approach could then also be applied to

NgxPermissionsModule.forChild({
	defaultRedirectTo: myFunction
})

Minimal reproduction of the problem with instructions

Environment

Angular version: X.Y.Z
ngx-permissions version: X.Y.Z


Browser:
- [ ] Chrome (desktop) version XX
- [ ] Chrome (Android) version XX
- [ ] Chrome (iOS) version XX
- [ ] Firefox version XX
- [ ] Safari (desktop) version XX
- [ ] Safari (iOS) version XX
- [ ] IE version XX
- [ ] Edge version XX

[AlexKhymenko]

@khodabandelu @timhoekstra What do You think, is it ok If You still have to specify redirectTo object (even empty) ?

 permissions: {
        only: 'ADMIN1',
          redirectTo: {}
      } as NgxPermissionsRouterData

This is use case when in the project You just want to block user coming to page, not to redirect him somewhere