incrementalBuild breaks with different groups using same resources

[muffl0n]

incrementalBuild breaks with different groups using same resources

[alexo]

This one is tricky :)

[muffl0n]

Thanks go out to my coworker who stresses wro4j with cascaded imports as if there were no tomorrow. :)

The only reason it works on the first run seems to be that the directory "generated2" does not exist. See ro.isdc.wro.maven.plugin.Wro4jMojo.isIncrementalCheckRequired():

@Override
  protected boolean isIncrementalCheckRequired() {
    return super.isIncrementalCheckRequired() && destinationFolder.exists();
  }

[alexo]

A possible solution could be holding a storage per group (which is expensive), or treating import statements differently when dealing with change detection...

[muffl0n]

My first idea was to store the hashes not only by path

/scss/header.scss=77141eb86ceb6a88beabe40d81fd1a65b5ce9e64

but also by group

base:/scss/header.scss=77141eb86ceb6a88beabe40d81fd1a65b5ce9e64
base2:/scss/header.scss=77141eb86ceb6a88beabe40d81fd1a65b5ce9e64

But I'm not sure if this is a good solution.

[alexo]

This is similar to have storage per group. The disadvantage is that there will be multiple checks for change for the same resource when it is referred from different groups.

I would prefer not checking twice for change. Instead of keeping a Map<String, Boolean> (<uri>, <change flag>), to keep Map<String, Map<String, Boolean> (where map holds the flag for each group).