Giter Site home page Giter Site logo

Comments (8)

AlexVerrico avatar AlexVerrico commented on June 27, 2024 1

Hi everyone.
As of version 1.1.0 you can now configure this on the settings page for the plugin in Octoprint.
Cheers,
Alex.

from octoprint-display-eta.

AlexVerrico avatar AlexVerrico commented on June 27, 2024

Hi @ShaneF1
This is on the roadmap for the project, but probably for a few months. Just to confirm, you have your pi set to 24hr time?

from octoprint-display-eta.

ShaneF1 avatar ShaneF1 commented on June 27, 2024

After setting TZ using "sudo dpkg-reconfigure tzdata" the local time is displayed in 24hr format. Is there a better way to do it?

from octoprint-display-eta.

AlexVerrico avatar AlexVerrico commented on June 27, 2024

I will have to do a bit of research about this, because I have the exact opposite situation, that is, I have set my time to display in 12hr format, but the ETA is displayed in 24hr format, so something clearly isn't right with with how we are setting the time display format, or with how the plugin finds out what format to use.

from octoprint-display-eta.

ShaneF1 avatar ShaneF1 commented on June 27, 2024

From my reading (I'm a python novice), this might benefit from the addition of ",get_locale()" in line 35 __init_py:

strtime = format_time(finish_time,get_locale())

from octoprint-display-eta.

AlexVerrico avatar AlexVerrico commented on June 27, 2024

Hi @ShaneF1
Thanks for the suggestion.
I have added that to the development branch, but can't test it for a couple of days, if you would like to assist in testing, you can install the updated version from here: https://github.com/AlexVerrico/Octoprint-Display-ETA/archive/devel.zip
Cheers,
Alex.

from octoprint-display-eta.

ShaneF1 avatar ShaneF1 commented on June 27, 2024

No, that didn't work. It gets tied up in a dependency chain which I don't have the experience to debug. For the moment I have hardcoded my time format.

strtime = format_time(finish_time,'HH:mm:ss')

from octoprint-display-eta.

joshuacant avatar joshuacant commented on June 27, 2024

My ETA time is also shown in 24h format even though I have run the tzdata reconfigure and picked a time zone that should be 12h (USA EDT). Perhaps a setting to toggle between the two formats would give people the control, rather than trying to determine it automatically, especially when a lot of people might never bother setting it correctly.

from octoprint-display-eta.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.