Giter Site home page Giter Site logo

Comments (10)

juddey avatar juddey commented on May 30, 2024 2

Hmm, this line causes the issue that you've found @jigartankhupp

import { LinearGradient } from "expo";

It looks like this component simply passes the props to the react-native-linear-gradient package underneath. The only catch is thatreact-native-linear-gradient uses native code so theres an extra install step. (The expo code insulates you from having to deal with the native deps)

@alexZajac Perhaps a non-expo and expo version of this package is needed, as long as we can reliably tell the difference between an expo and non-expo project.... Thoughts?

from react-native-skeleton-content.

alexZajac avatar alexZajac commented on May 30, 2024 2

@jigartankhupp I will definitely create a version for non-expo projects, because as @juddey mentionned, using the react-native-linear-gradient package introduces some native code, which can't be included as such in an Expo project. Similarly, it's a pain for Expo projects to try including the native package.

from react-native-skeleton-content.

jigartankhupp avatar jigartankhupp commented on May 30, 2024

@juddey Yes, correct it seems I can fork and install react-native-linear-gradient instead of LinearGradient from expo so it will be run on non-expo project. What do you think it will be the correct approach or not?

from react-native-skeleton-content.

juddey avatar juddey commented on May 30, 2024

Yes @jigartankhupp thats certainly a solution for non-expo projects. I'm not familiar enough with expo though to know what to do to ensure compatibility.

from react-native-skeleton-content.

jigartankhupp avatar jigartankhupp commented on May 30, 2024

Personally, I like to work on a non-expo project. I agree that expo provides good libraries and live reload on the app without a cable but losing native packages is not an ideal thing.

from react-native-skeleton-content.

efec89 avatar efec89 commented on May 30, 2024

I'm waiting non-expo version too. Thanks :)

from react-native-skeleton-content.

alexZajac avatar alexZajac commented on May 30, 2024

@jigartankhupp @efec89 I made the nonexpo package version, please check it out here, and give me some feedback because I'm not able to test it right now. If changes are required, let me know.

from react-native-skeleton-content.

jigartankhupp avatar jigartankhupp commented on May 30, 2024

@alexZajac Thank you.

from react-native-skeleton-content.

tjboudreaux avatar tjboudreaux commented on May 30, 2024

@alexZajac when I install react-native-skeleton-content-nonexpo, there isn't any source in the installed directory.

from react-native-skeleton-content.

alexZajac avatar alexZajac commented on May 30, 2024

Hi @tjboudreaux !
The package doesn't include any src folder because as it's written in Typescript, I made the choice to only include the src directory on Github but not on the package itself.
The lib folder is the result of building the Typescript files to Javascript, and is included in the latest version.

from react-native-skeleton-content.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.