Comments (1)
@epatters while looking at this I noticed an apparent oddity, in the BipartiteGraphs
module the methods to remove vertices and edges are typed for AbstractBipartiteGraph
as opposed to the rest of the getters/setters which are typed for HasBipartiteGraph
, see https://github.com/AlgebraicJulia/Catlab.jl/blob/main/src/graphs/BipartiteGraphs.jl#L254-L288
This is relevant because in my current design I follow the version for basic graph property graph. That is, the type of the acset graph
in the struct PropertyGraph
should be a subtype of HasGraph
. If I do something similar for bipartite graphs and make the type of the bipartite acset in BipartitePropertyGraph
be a subtype of HasBipartiteGraph
, the methods for remove vertices won't "forward" properly, as the type class is too wide for those ones.
I suspect that the intention was to have those methods in the BipartiteGraphs
module actually take HasBipartiteGraph
as the type of the first argument, but want to confirm with you.
from catlab.jl.
Related Issues (20)
- Move from JSON.jl to JSON3.jl
- Constraints on attributes in `maximum_common_subobject` HOT 5
- Maximum_common_subobject changes ordering
- Refactor FinSets from FinSetImpls, etc
- Add features to VM based hom search
- Ambiguities detected from Aqua
- Question about abstract vs. concrete type in `enumerate_paths` HOT 2
- `SigmaMigrationFunctor` method uses an undefined variable HOT 2
- Bug in `product` keyword arguments
- free-floating URLs not parsed well by documenter HOT 1
- Coproduct with looseACSetTransformations HOT 2
- Parameters in queries for attributes that are unions HOT 3
- Keyword argument for sending attrvars to other attrvars
- `Homomorphism` should error if there are multiple homomorphisms
- `representable` fails on attribute types
- Methods missing for drawing schemas
- Scalars in acset transformations HOT 3
- `join` does not work for subobjects using `ACSetTransformation`
- `query` errors when specifying parameters HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from catlab.jl.