Giter Site home page Giter Site logo

Comments (1)

slwu89 avatar slwu89 commented on September 23, 2024

@epatters while looking at this I noticed an apparent oddity, in the BipartiteGraphs module the methods to remove vertices and edges are typed for AbstractBipartiteGraph as opposed to the rest of the getters/setters which are typed for HasBipartiteGraph, see https://github.com/AlgebraicJulia/Catlab.jl/blob/main/src/graphs/BipartiteGraphs.jl#L254-L288

This is relevant because in my current design I follow the version for basic graph property graph. That is, the type of the acset graph in the struct PropertyGraph should be a subtype of HasGraph. If I do something similar for bipartite graphs and make the type of the bipartite acset in BipartitePropertyGraph be a subtype of HasBipartiteGraph, the methods for remove vertices won't "forward" properly, as the type class is too wide for those ones.

I suspect that the intention was to have those methods in the BipartiteGraphs module actually take HasBipartiteGraph as the type of the first argument, but want to confirm with you.

from catlab.jl.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.