Giter Site home page Giter Site logo

Comments (2)

jsha avatar jsha commented on May 28, 2024 1

I'd like to avoid magic numbers if we can.

It seems like there is arguably room for another extension point. We have Resolver, which turns names into IP addresses. We have TlsConnector, which turns a dialed TCP connection into a TLS stream. We could add Dialer, which creates a TCP (or other socket) connection. For the Fortanix use case described above this would require a fake Resolver that doesn't actually do name resolution, but that's doable.

from ureq.

algesten avatar algesten commented on May 28, 2024

Wonder if we could solve this without changing the API with an internal hack?

We could make up a magic number IPv6 SocketAddr, which when returned from a resolver, triggers the behavior of passing the hostname straight to TcpStream::connect.

from ureq.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.