Comments (3)
One possible way: rather than implementing Clone
(which is infallible), we could have a try_clone()
which only succeeds if there is no Middleware
.
from ureq.
Hi @lefuturiste and welcome to ureq!
While I don't object in principle to have AgentBuilder
implement the Clone
trait, there is a hurdle which makes it hard in the short term, and that is Middleware
.
The Agent/builder contains: this:
middleware: Vec<Box<dyn Middleware>>,
There is currently no requirement of Middleware
to implement Clone
, which means this Vec
of middlewares are not clonable either. This leads to one of two solutions:
- Require
Middleware
to beClone
. This would be a breaking change and force a major version. We have no appetite for that right now, but we've started aFUTURE.md
doc in the root where we can add this as a potential consideration for a future major version. - Arc/Mutex lock the middleware chain. This would not be great for performance because Agent manages a pool of connections with the intention of being able to handle many parallel requests. Arc/mutex in that mix would work against those intentions.
from ureq.
That's a nice idea.
Or clone_without_middleware
if we want to be very specific.
from ureq.
Related Issues (20)
- Timeout not working when having packet losses HOT 1
- Support Multipart Forms HOT 1
- Timeout not always respected HOT 5
- Invalid transformation to http::Response<Vec<u8>> for non utf8 response bodies HOT 3
- Example of requesting a continuous stream HOT 1
- Timeout not taking in consideration TimeoutConnect HOT 2
- ureq 2.9.3 fails to compile with errors in `hoot` HOT 3
- `ureq` 2.9.3 compilation fails due to `hoot` requiring rustc 1.65 HOT 4
- Keep-alive is disabled when using SOCKS HOT 1
- Update requirement of `url=2.3.1` HOT 3
- hootbin is a required dependency HOT 2
- Stream panics in drop during test
- Redirect history not available HOT 2
- Add support for configuring default headers in AgentBuilder HOT 1
- Potential to modify ordering for IS_TEST in lib module HOT 1
- Change `send_json` `data` argument HOT 4
- Add `Error::as_response` HOT 3
- Middleware cannot modify query string parameters? HOT 2
- Decide what to do about rustls defaulting to aws-lc-rs instead of ring HOT 12
- Agent should be able to accept `http::Request` HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ureq.