Comments (5)
Good catch. See PR #122
from go-algorand.
The buffer always contain the last bits (see line 167) so it provides the same result. Can you provide an example that produces an incorrect result?
from go-algorand.
The check looks at the value of buffer, so if all the bits are zero, then nothing happens in the current code.
from go-algorand.
The current use of the function won't raise the issue because when a mnemonic is generated, it is padded with extra zeroes and, when converted back to a pk, as the code says, 264 bits is a multiple of 8.
But in the future, if the function is used with other purpose, the problem may appear if the last processed bits are not zero.
Also you can refer to the original stackoverflow code where accBits
is checked in the flush
function.
from go-algorand.
Excellent 😊
from go-algorand.
Related Issues (20)
- Official docker images are incompatible with windows server workers on github actions HOT 3
- Build: Flaky Ledger Catchup StateProof Verification Test
- The `DisableAPIAuth` config option causes requests to error if any auth token is present HOT 2
- As a beginner, how should I build my own chain? HOT 3
- The security vulnerability bounty page is "Not Found"
- Missing LedgerStateDelta from OAS spec (and therefore documentation and other SDKs apart from Go) HOT 1
- Measure consensus Nakamoto coefficient HOT 5
- goal should make extra information provided in some API requests available HOT 1
- Documentation and Config Generation: non-archival relays should retain last 20K or more blocks
- There are 11 pages of GitHub issues, some as old as 2019. Let's clean this up? HOT 1
- simulate fails with empty signature on a rekeyed account HOT 15
- Catchpoint is very slow HOT 3
- Add option to store and retrieve deltas HOT 2
- Node's ready status is incorrect while the node is starting HOT 2
- Buggy test?
- increase max lsig program size HOT 6
- Add access to incentive related consensus parameters HOT 3
- 3.24.0 - make - version of quic-go not supporting Go 1.21 HOT 1
- Algod docker image configuration support for ColdDataDir HOT 1
- request body too large HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from go-algorand.