Conversion from uint11 to byte array may lead to wrong result.

[algorand]

Conversion from uint11 to byte array may lead to wrong result.

[rotemh]

Good catch. See PR #122

[rotemh]

The buffer always contain the last bits (see line 167) so it provides the same result. Can you provide an example that produces an incorrect result?

[zeldovich]

The check looks at the value of buffer, so if all the bits are zero, then nothing happens in the current code.

[mxmauro]

The current use of the function won't raise the issue because when a mnemonic is generated, it is padded with extra zeroes and, when converted back to a pk, as the code says, 264 bits is a multiple of 8.

But in the future, if the function is used with other purpose, the problem may appear if the last processed bits are not zero.

Also you can refer to the original stackoverflow code where accBits is checked in the flush function.

[mxmauro]

Excellent 😊