P2P HTTP Implementation: open problems

[algorandskiy]

P2P HTTP Implementation: open problems

[algorandskiy]

AFAICT most of the code added to the RequestTracker from #1390 (and mirrored in feature/p2p for p2p http conns) can be replaced with two lines by the Go 1.20 ResponseController feature https://tip.golang.org/doc/go1.20#http_responsecontroller like in their example — vastly easier than managing a conn tracking middleware system

The ResponseController type provides a clearer, more discoverable way to add per-handler controls. Two such controls also added in Go 1.20 are SetReadDeadline and SetWriteDeadline, which allow setting per-request read and write deadlines. For example:

func RequestHandler(w ResponseWriter, r *Request) {
  rc := http.NewResponseController(w)
  rc.SetWriteDeadline(time.Time{}) // disable Server.WriteTimeout when sending a large response
  io.Copy(w, bigData)
}