Comments (1)
Hmm, that is tricky. Calling System.setProperty could have sideeffects if someone includes our client in their code base, but have OTHER http clients that have useSystemProperties() enabled. In my opinion this makes option 2 not ideal. From reading the apache source code, I don't see an easy way to work around this.
I think option 1 seems like the least bad option. I grepped the apache source code for System.getProperty and it appear there are only 4 proxy properties used here:
https://github.com/apache/httpcomponents-client/blob/22902593e78d56423709b66abf4757082ddced50/httpclient5/src/main/java/org/apache/hc/client5/http/impl/auth/SystemDefaultCredentialsProvider.java#L141
from algorithmia-java.
Related Issues (13)
- AlgoFailure interface
- DataObject.toString isn't connector aware
- DataFile.put Documentation and Usage HOT 3
- Algorithmia.client() call fails HOT 7
- com.algorithmia.APIException: 308 unexpected API response HOT 5
- Broken Maven deployment dependencies - sbt-pgp and sbt-sonatype
- Decoding UTF-8 bug
- Prefix string too short exception when "data://
- Prefix string too short exception when getting "data://" HOT 7
- AlgorithmiaClient cli = Algorithmia.client(GlobalVariables.ALGORITHMIA_KEY); fails
- Missing URL encoding of data_uri HOT 1
- Async http connections limited per client HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from algorithmia-java.