Giter Site home page Giter Site logo

Comments (7)

rustybrooks avatar rustybrooks commented on June 26, 2024 1

New version is out that includes your PR (I modified the defaults as suggested in the PR): 1.5.12

from otx-python-sdk.

rkagin avatar rkagin commented on June 26, 2024

This would be done in the initialization, and the get, patch, and post functions.

from otx-python-sdk.

rustybrooks avatar rustybrooks commented on June 26, 2024

Can you submit a PR or send me details to [email protected]?

from otx-python-sdk.

rkagin avatar rkagin commented on June 26, 2024

I made a pull request at #60.

from otx-python-sdk.

rustybrooks avatar rustybrooks commented on June 26, 2024

It looks pretty straightforward - I'll test that it doesn't break anything but it's difficult for me to verify that it "works" if you pass values in for the new parameters. I assume that you've used it this way behind a proxy?

I'll look at it tomorrow for inclusion into the library.

from otx-python-sdk.

rkagin avatar rkagin commented on June 26, 2024

Yes, I've used this when I set the parameters, but probably could have tested the default values. In requests, verify defaults to boolean True but also takes a local path to a CA_BUNDLE file (how I use it). The cert parameter defaults to None but also takes a local path to a client certificate.

from otx-python-sdk.

rustybrooks avatar rustybrooks commented on June 26, 2024

OK well, like I said if it passes the "normal" tests then it's probably no worse than it is now. I'l research the defaults a bit to satisfy myself and if it passes tests then we should be good to go. Thanks for your contribution.

from otx-python-sdk.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.