Two extra spaces added before line breaks

[alir3z4]

Two extra spaces added before line breaks

[Alir3z4]

I'm not really sure the design decision behind having that extra space.
@theSage21 any idea?

@sirdodger If no specific reason is behind this, a flag is welcome to switch this thing off explicitly

[theSage21]

After some digging I found that this particular line of code was written at aaronsw@7a327b8. Since he has passed away, and this was an initial commit, I cannot comment on the purpose of this code.

We can safely do away with this though it is notewhile to remember that some tests fail on changing this behaviour. In my opinion we should correct this completely without leaving a flag or so which will only bloat the codebase.

To support the last decision, since this has gone unreported for so long chances of people being affected by it are relatively low. When we change this, the worst that happens is that their tests fail, and changelog can mention that this is to be expected.

@Alir3z4 @sirdodger sound ok?

[Alir3z4]

From my point of view I can't figure out the reason for this behavior.
If others also can't find a reasonable design decision behind this then my vote would go for having a flag to switch it off and remove the extra spaces from the output, which means no one's tests will fail since the default will be having the two extra spaces and the flag would be to switch this behavior.

[theSage21]

@Alir3z4 @sirdodger If I remember correctly, two spaces at the end of a line specify a new line in Markdown. This is in github too I think.

This is line 1.
This is line 2.
There are two spaces at the end of this line.  
This is line 4.

This is line 1.
This is line 2.
There are two spaces at the end of this line.
This is line 4.

Maybe we should let this be? It is a feature of Markdown after all.

--edit--

Ok. This is a feature. I vote that this remains untouched.

[Alir3z4]

Yes <br> is 2 spaces in markdown.
That's correct, what I was thinking.

The issue is closed and marked as invalid.

[sirdodger]

Thanks for the clarification!