Giter Site home page Giter Site logo

Comments (5)

regehr avatar regehr commented on May 16, 2024

Nevermind, I think I see what happened. in the original version the UF returned a true value for isdigit() but 98 isn't a digit, and things went badly after that.

from alive2.

regehr avatar regehr commented on May 16, 2024

found a few more examples of this pattern, with abs() and labs()

I propose we work around these problems in the obvious, clunky way: by teaching alive about the semantics of these functions. let me know if this seems ok, Nuno.

from alive2.

nunoplopes avatar nunoplopes commented on May 16, 2024

This is LLVM's SimplifyLibCalls kicking in. Looking at the sheer size of the file, it seems almost impossible to catch up.
Either we can source the spec from somewhere and convert it automatically, then we would end up mostly copying that file, adding little value. I don't know if there are C libs specs out there, but there might be (Deepspec folks?).

A solution might be to simply disable SimplifyLibCalls by tagging everything with the nobuiltin attribute. It's unfortunate, but it seems to be the only realistic approach ATM.
Yet another approach would be to support the top-10 most common functions and only tag the remaining with nobuiltin.
What do you think?

from alive2.

regehr avatar regehr commented on May 16, 2024

I'll try adding support for a few of these that come up most often, and see how it goes. If this ends up being a stupid approach we can rip out the code and try something different.

from alive2.

nunoplopes avatar nunoplopes commented on May 16, 2024

The framework to recognize known functions is in: 40333f2
Only 1 function is recognized right now. But it won't generate false-positives like this bug; will simply skip verification.
Now we "just" need to write the spec for the other known functions..

from alive2.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.