Giter Site home page Giter Site logo

Comments (6)

rozek avatar rozek commented on August 11, 2024 1

well,

it actually took much longer than expected to get the tool running: I had to make so many changes (including a switch to wget for the actual download rather than using a headless Firefox for that purpose) that I made these changes in my own fork of this repo

But now, the icons are downloading!

from svg_repo_dl.

rozek avatar rozek commented on August 11, 2024

After many other changes (e.g., the script needs Firefox as a prerequisite and a configuration which allows it to run in headless mode) I finally succeeded in connecting to svgrepo.com.

However, there, it did not find any link to download...(sigh)

from svg_repo_dl.

rozek avatar rozek commented on August 11, 2024

ah, I also had to change the CSS selector used to locate the various icons: it should now be

.style_Node__7ZTBP a

Now, I get the first page of a whole collection, at least

from svg_repo_dl.

AllanCerveaux avatar AllanCerveaux commented on August 11, 2024

Thanks for your interest in this old project, which met one of my needs a long time ago.
It's cool that you took the time to adapt it to your needs.

If you want, you can make a PR to contribute, that would help a lot of other people who want to use this tool or if you allow me I can add my own solution.

from svg_repo_dl.

rozek avatar rozek commented on August 11, 2024

I would be honored to provide a pull request.

However, since I'm not a regular Python programmer, I can only claim that my code "works on my machine".

Thus, it would be nice if you could test my changes on your machine as well - everything has been prepared to be used out-of-the-box (the code currently even refers to my fork rather than your repo)

If everything works fine, I'll change all references back to your repo again and prepare the actual pull request.

What I forgot: your list of "requirements" seems to be incomplete - you may want to update it - just use my Dockerfile as a basis.

from svg_repo_dl.

drzraf avatar drzraf commented on August 11, 2024

Can likely be closed, now

from svg_repo_dl.

Related Issues (3)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.