Comments (7)
I read the Apple HIG and I get the impression that a source list should only be used if it is the primary means of navigating the app (in some loose sense). They also say that a source list should never be more than two levels deep. All in all I get the impression that a source list for the file browser feature would go against the HIG, so I am inclined to say that we should not use the source list style.
Maybe it would be nice if the background color adapted itself to the setting of the bg
option however. It is hard on the eyes with a white background in the file browser if you have a dark color scheme. I'm not sure how it should be handled though. We could try using the same background/foreground combination as is used by the text view, but I'm a bit dubious about this as well. Perhaps we should just have two presets for dark/light and toggle between these two depending on what bg
is set to? Hmmm....I think I'm going off on a tangent here...
from macvim.
Ah, I quickly skimmed the HIG but didn’t see that text about source lists that you mention. My gut feeling was the same, but since people asked about it and I couldn't find it in the HIG I thought I’d make a note to investigate it more. So if the HIG mentions about it not going down more than two levels then we know enough, it's not a thing we should do.
What do you mean by using the same bg/fg colors as the text view being ‘dubious’? Is it hard to get these values? Because I think we should simply try it and see how it works out to be able to really say anything about it. If that doesn't work out, then I agree we should at least provide two presets; for a light and a dark bg.
from macvim.
Hmmm...yes what did I mean by that? My thoughts were something like:
- the icons may blend in with the background color
- I think (maybe) that the file browser should be visually distinct from the text view
- background/foreground colors that look good for the text view may look bad for the file browser (this is basically the same as the first point)
I can't think of anything else right now.
If you want to try it out then you can get the background/foreground colors from -[NSWindowController setDefaultColorsBackground:foreground:]
and simply pass those on to the file browser. I'd like to try it out too if you write a patch.
from macvim.
Oh, here is the HIG link to source lists. I only read it very briefly a few weeks ago so it may be what I said earlier is not true. Take a look yourself and see what you think.
from macvim.
My memory served me right, it clearly states that "A source list should not contain more than two levels of hierarchy", right under Figure 14-24. So I'm still leaning towards not using the source list style.
from macvim.
Agreed, we’re not going to do this. I will create a new issue regarding the background/foreground colors of the text view.
from macvim.
Created new ticket regarding fg/bg colors: #23.
from macvim.
Related Issues (20)
- Core text renderer causing squared off window corners HOT 2
- Opening directory in sidebar by keyboad has no effect HOT 5
- Cannot open any windows HOT 4
- Project root?
- Merging into upstream HOT 1
- Option to jump to existing tab/window/buffer on enter HOT 1
- Rename in File Browser opens newly renamed file in current tab. HOT 3
- Changing font size does not correctly resize window.
- Sidebar file sorting issues HOT 2
- Reveal File in Browser HOT 4
- Split screen causes visual issue at lower left / command line
- `tgetent()` failed on MacOSX 10.9 HOT 1
- `error: conflicting types for 'sigaltstack'` when compiling on MacOSX 10.9 HOT 6
- undefined symbol `_ruby_errinfo` on MacOSX 10.9 HOT 5
- `error: conflicting types for 'sigaltstack'` when compiling on MacOSX 10.10
- balloon tooltips don't work
- Using the keyboard to open directories does not work HOT 1
- window resize is slow
- Please Provide OSX Binaries. Build Requires Full Install of Xcode HOT 1
- Upgrade to Vim 8? HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from macvim.