Investigate replaced Whitehall attachment on discarded edition

[floehopper]

Investigate replaced Whitehall attachment on discarded edition

[elliotcm]

I've now gone through this myself.

I've followed the steps above on integration and could not reproduce the issue. Everything in whitehall's DB wound up as you would expect.

I do agree that the attachments listed above ended up in an odd non-deleted state while the edition itself is marked as deleted which appears impossible due to the code linked above which deletes all attachments when the edition is deleted

However, the code for this asset deletion was added 23 March 2016, while the edition in question was discarded 9 May 2014. The commit where the code was added calls this situation out specifically, though it leaves out the asset manager issue as it was presumably not a thing for whitehall at the time.

I'm guessing that when the assets were imported from whitehall to asset manager this discrepancy was copied over accidentally.

[floehopper]

Note that I had a go at extending the relevant integration test to include this scenario in this branch, although I'm not sure it's quite right.

[floehopper]

I think there might be an issue with AttachmentData#deleted?, because it looks as if it only takes into account whether the edition has been deleted; I think it should also take into account whether the Attachment is marked as deleted, i.e. when a single attachment is deleted and the edition is not deleted.

[floehopper]

I think there might be an issue with AttachmentData#deleted?, because it looks as if it only takes into account whether the edition has been deleted; I think it should also take into account whether the Attachment is marked as deleted, i.e. when a single attachment is deleted and the edition is not deleted.

I don't think the above statement about AttachmentData#deleted? is true after all. I think I must've been confused by the mention of "attachable" in the include_deleted_attachables option passed to AttachmentData#significant_attachment.

In fact, as the name clearly suggests, the latter returns an instance of an Attachment and thus AttachmentData#deleted? does take account of whether the attachment has been marked as deleted.

I thought this was worth clarifying, but note that this doesn't resolve the original problem as described in the issue description.

[thomasleese]

Closing this as the investigation is complete and we have a card to complete the follow up work.