Comments (3)
boffbowsh
commented on June 1, 2024
What's different about this that's not mitigated by setting a policy.xml for imagemagick?
from whitehall.
alexmuller
commented on June 1, 2024
The policy.xml will restrict what ImageMagick is able to do but there's an underlying problem in that we were able to get the exploit through whitehall by simply changing the file extension from mvg to jpg. I think that's what the linked issue is referring to - carrierwave should be more robust when checking what kind of file is being uploaded, and we should blacklist things that don't match image formats we accept.
from whitehall.
floehopper
commented on June 1, 2024
This might've been fixed in #3273.
from whitehall.
Related Issues (20)
- Historic appointments could be consolidated further
- Remove commit - Content for "theresa-may" missing HOT 1
- Missing Local data - images
- Running tests results 404 API error
- Bad file descriptor (Errno::EBADF) - individual tests HOT 2
- Missing local data - World Locations HOT 2
- Page failing to render locally - Announcements
- Broken link reporter test HOT 1
- Announcements page - content
- Consider replacing IDs with data-* attributes HOT 1
- Pluralisations quirk will cause fallbacks to English locale
- Prevent ministers and officials from hiding substantial policy paper changes as minor HOT 5
- Add View Components HOT 5
- Consider using pdf.js for PDF thumbnail generation, or even just use a generic icon instead.
- Links in component guide are broken
- When updating a slug for an edition, trailing spaces cause a crash
- Topical Events logos cannot be SVGs
- Advisory text for custom organisation logos appears to be incorrect
- Lack of checking for duplicate titles/URLs
- 'Back' link doesn't work in organisation pages, Promotional Feature
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from whitehall.