Comments (6)
robinwhittleton
commented on June 12, 2024
Link to the ar version should have lang="ar" and hreflang="ar". The ar page should have <main lang="ar"> with appropriate lang="en" sections.
from whitehall.
rubenarakelyan
commented on June 12, 2024
#2895 and alphagov/government-frontend#204 need to be built-upon to add the hreflang attribute.
from whitehall.
robinwhittleton
commented on June 12, 2024
I might be wrong about hreflang actually as the whole page is still lang="en", it just has alternate language sections. The lang Attribute is still needed.
from whitehall.
rubenarakelyan
commented on June 12, 2024
But if the majority of the content on the page is in another language, is lang="en" still right for the <html> tag, or should we instead be marking up English where it appears?
from whitehall.
robinwhittleton
commented on June 12, 2024
Yeah, <html lang="en"> is correct on GOV.UK. In terms of tree structure, the top level content (i.e. header and footer) is in English, and it’s only when you get into the content that you would need to mark that up as lang="xx". HTML language works on the tree rather than majorities.
from whitehall.
tijmenb
commented on June 12, 2024
Now tracked https://trello.com/c/O3Dqb6HR/40-fix-screen-reading-for-translated-pages, because it's not a Whitehall-specific issue.
from whitehall.
Related Issues (20)
- Historic appointments could be consolidated further
- Remove commit - Content for "theresa-may" missing HOT 1
- Missing Local data - images
- Running tests results 404 API error
- Bad file descriptor (Errno::EBADF) - individual tests HOT 2
- Missing local data - World Locations HOT 2
- Page failing to render locally - Announcements
- Broken link reporter test HOT 1
- Announcements page - content
- Consider replacing IDs with data-* attributes HOT 1
- Pluralisations quirk will cause fallbacks to English locale
- Prevent ministers and officials from hiding substantial policy paper changes as minor HOT 5
- Add View Components HOT 5
- Consider using pdf.js for PDF thumbnail generation, or even just use a generic icon instead.
- Links in component guide are broken
- When updating a slug for an edition, trailing spaces cause a crash
- Topical Events logos cannot be SVGs
- Advisory text for custom organisation logos appears to be incorrect
- Lack of checking for duplicate titles/URLs
- 'Back' link doesn't work in organisation pages, Promotional Feature
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from whitehall.