Comments (7)
Has also happened in https://govuk.zendesk.com/agent/tickets/2446037
from whitehall.
@h-lame Did Whitehall admin disable SRI attributes in the end?
from whitehall.
"More" should probably link to a page that shows those navigation options. Then JS can prevent that link from triggering and show the dropdown for users with working JS.
from whitehall.
The ticket to fix this this is on our doing board. https://trello.com/c/2wYn3eJi/202-new-document-tab-does-not-display-dropdown (well, it's actually the new document tab but it's the same problem). Would be good to discuss/pair @fofr.
from whitehall.
@fofr I haven't removed SRI from the admin template, and it doesn't look like anyone else has either.
If it's causing lots of problems because of publishers working on networks that are monkeying around with the assets then removing SRI (even though it's doing its job properly!) seems like a pragmatic workaround for the problem. It'd be good to couple that with a spike/reivew to work out the scale of the problem as I suspect it's not just the more tab or new document tab. I wouldn't be surprised if large parts of whitehall admin were not progressively enhanced at all, so fixing just the bits that have been reported won't be enough. Once we've completed that review and fixed any problems we find we should be safe to re-introduce SRI safe in the knowledge that any monkeying about with the assets will be blocked, but also the publishers will still be able to get their work done.
from whitehall.
@h-lame Completely agree. Suggested to @gpeng that we audit Whitehall for JS only features.
from whitehall.
On the backlog 👍 https://trello.com/c/Ly0hzsOT/1098-some-functionality-in-whitehall-admin-doesnt-work-at-all-without-javascript
from whitehall.
Related Issues (20)
- Large-sized numbers have strange underlines on /government/get-involved HOT 2
- Historic appointments could be consolidated further
- Remove commit - Content for "theresa-may" missing HOT 1
- Missing Local data - images
- Running tests results 404 API error
- Bad file descriptor (Errno::EBADF) - individual tests HOT 2
- Missing local data - World Locations HOT 2
- Page failing to render locally - Announcements
- Broken link reporter test HOT 1
- Announcements page - content
- Consider replacing IDs with data-* attributes HOT 1
- Pluralisations quirk will cause fallbacks to English locale
- Prevent ministers and officials from hiding substantial policy paper changes as minor HOT 5
- Add View Components HOT 5
- Consider using pdf.js for PDF thumbnail generation, or even just use a generic icon instead.
- Links in component guide are broken
- When updating a slug for an edition, trailing spaces cause a crash
- Topical Events logos cannot be SVGs
- Advisory text for custom organisation logos appears to be incorrect
- Lack of checking for duplicate titles/URLs
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from whitehall.