Giter Site home page Giter Site logo

Comments (7)

thomasleese avatar thomasleese commented on June 12, 2024

Has also happened in https://govuk.zendesk.com/agent/tickets/2446037

from whitehall.

fofr avatar fofr commented on June 12, 2024

@h-lame Did Whitehall admin disable SRI attributes in the end?

from whitehall.

fofr avatar fofr commented on June 12, 2024

"More" should probably link to a page that shows those navigation options. Then JS can prevent that link from triggering and show the dropdown for users with working JS.

from whitehall.

gpeng avatar gpeng commented on June 12, 2024

The ticket to fix this this is on our doing board. https://trello.com/c/2wYn3eJi/202-new-document-tab-does-not-display-dropdown (well, it's actually the new document tab but it's the same problem). Would be good to discuss/pair @fofr.

from whitehall.

h-lame avatar h-lame commented on June 12, 2024

@fofr I haven't removed SRI from the admin template, and it doesn't look like anyone else has either.

If it's causing lots of problems because of publishers working on networks that are monkeying around with the assets then removing SRI (even though it's doing its job properly!) seems like a pragmatic workaround for the problem. It'd be good to couple that with a spike/reivew to work out the scale of the problem as I suspect it's not just the more tab or new document tab. I wouldn't be surprised if large parts of whitehall admin were not progressively enhanced at all, so fixing just the bits that have been reported won't be enough. Once we've completed that review and fixed any problems we find we should be safe to re-introduce SRI safe in the knowledge that any monkeying about with the assets will be blocked, but also the publishers will still be able to get their work done.

from whitehall.

fofr avatar fofr commented on June 12, 2024

@h-lame Completely agree. Suggested to @gpeng that we audit Whitehall for JS only features.

from whitehall.

gpeng avatar gpeng commented on June 12, 2024

On the backlog 👍 https://trello.com/c/Ly0hzsOT/1098-some-functionality-in-whitehall-admin-doesnt-work-at-all-without-javascript

from whitehall.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.