Giter Site home page Giter Site logo

Comments (2)

alphapapa avatar alphapapa commented on May 28, 2024

Hi,

Calling this a "mode" is confusing. All the other "modes", like "lisp-mode" and "org-mode", are buffer modes that affect buffer behavior. Calling the variable "org-super-agenda-active" rather than "org-super-agenda-mode" would be less confusing. I was also initially looking for something on the mode-line, which would only be appropriate if this were a buffer mode.

Well, it's a global minor mode, so the convention is for the variable to end in -mode. And as you said, since it's not a buffer mode, there's no need for a lighter. I think this is the standard way to do this in Emacs.

The other problem results from with my issues with MELPA. I have a personal git area where I modify parts of org-mode and other packages. MELPA corrupts my org-mode when it installs it as a dependency. I have not dug through MELPA lisp code to figure how to stop this. Org-super-agenda lists org as a dependency, so MELPA corrupted it.

I also keep elpa/ in git, but I don't have any corruption issues like you describe. The only reason installing this package would have installed Org is if you didn't already have Org installed at the version required.

I'm not sure exactly what kind of changes you're making to packages, but you should be able to revert any changes made by installing dependencies by using git. e.g. in Magit you can just open the status buffer and press k on any changes you don't want, and they will be reverted to the HEAD commit.

And I don't think "corrupting" is what's happening, because that's not how package.el works. It just installs a new version in a new directory, like mine is /home/me/.emacs.d/elpa/org-plus-contrib-20170210. If I upgrade Org, it will be in a new directory like /home/me/.emacs.d/elpa/org-plus-contrib-20170814, and the old directory will remain untouched. So if you simply delete the newest Org directory, that will cause Emacs to load the old one next time.

I'm afraid there's not much I can do for you if you're modifying packages directly in the elpa/ directory. Generally there should not be any need to make changes that way, because you can do nearly anything with custom functions, keymaps, hooks, and function advice. That's even how this package works, by wrapping an Org function and filtering its output.

If you insist on making changes directly to installed packages, you probably need to use an alternative package manager, like maybe borg, which is designed to help users make changes to packages directly.

A discussion of dependencies and how to install without MELPA would help. Reading the lisp code and figuring out the dependencies was not too hard, but it was time consuming.

Good point, I'll add a list of dependencies to the readme.

Thanks for your feedback.

from org-super-agenda.

rjhorn-agfa avatar rjhorn-agfa commented on May 28, 2024

I missed that it was a global minor mode. So the name is appropriate.

I don't put my version of org-mode into the elpa directory. MELPA did, and the result acted like a mixed installation of org. The fix was to simply delete the elpa directory. There is probably some way to tell elpa that I'm providing org and it should accept that the dependency has been met. I haven't noticed it.

from org-super-agenda.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.