Giter Site home page Giter Site logo

Comments (13)

MaximeBaudette avatar MaximeBaudette commented on August 27, 2024

@lvanfretti
Could you specify the motivation behind having a specific examples run at the end of the installation ?

Since we implemented the test of dependencies in the installation script, I haven't experienced any situation where no error raised in the install process was coupled to a non working Rapid toobox

from rapid.

lvanfretti avatar lvanfretti commented on August 27, 2024

@MaximeBaudette what I would like is to make sure that at least the basic example would run without any human intervation.

The most natural thing would be to do it right at installation, but I guess we can have a simple test script for debbuging dependencies and installation. My simple example is ideal for that because it will not put a lot of burden to the machine, and is small enough to set up several tests of the different functionalities and options of the tool.

If someone reports a bug, we can ask to display the output of the installation script or test script.

If you guys can get my basic script working again, and give me an hour or such, I can create some examples / cases of what we want to test.

Finally, it is also a pretty nighfty thing to have the user get something already running when they install rapid so they can start playing... so that was why I want it in the installation, but if you want to make it a separate test script, that is fine with me.

from rapid.

tinrabuzin avatar tinrabuzin commented on August 27, 2024

@lvanfretti If you check out the two pull request you can see how I implemented it now... But, ofc, I'll adapt it to yours and Maxime's decision.

from rapid.

lvanfretti avatar lvanfretti commented on August 27, 2024

@tinrabizin you will have to show me, I don't have my M$ Guidos image with me.

from rapid.

MaximeBaudette avatar MaximeBaudette commented on August 27, 2024

@tinrabuzin I'll approve the pull request for now.
I still find this solution to be an overkill, as windows are opened for simulink, the graph visualization...
We can think of another to do it in the future, but for now this is what will be implemented

from rapid.

lvanfretti avatar lvanfretti commented on August 27, 2024

@MaximeBaudette there are commands to close the simulink model automatically.
It doesn't even need to be opened... but maybe that's inside either the rapid workflow or the FMI workflow.

from rapid.

tinrabuzin avatar tinrabuzin commented on August 27, 2024

@MaximeBaudette @lvanfretti For some reason, the model is closed automatically, at least on my computer. However, I open the model on purpose. To prevent it, you can just remove the two lines starting with open_system.

from rapid.

MaximeBaudette avatar MaximeBaudette commented on August 27, 2024

to get me wrong, it gets closed upon completion, but it is open during the iterations

from rapid.

lvanfretti avatar lvanfretti commented on August 27, 2024

@tinrabuzin which workflow opens the simulink model? Is it RaPId or the FMI?
If it is RaPId, I guess we can use this: link.
If it is the FMI Toolbox, then we have to check if there is an option to set the default to 'don't open the simulink model'.

from rapid.

tinrabuzin avatar tinrabuzin commented on August 27, 2024

@lvanfretti I opened it with my script on purpose wtih open_system. I'll remove this now.

from rapid.

MaximeBaudette avatar MaximeBaudette commented on August 27, 2024

now I added some try catch around the example.
it would be off course awesome to add custom message depending on the error code received, but for now we'll be fine wih "something went wrong"

from rapid.

janlav avatar janlav commented on August 27, 2024

@MaximeBaudette is this issue resolve now?

from rapid.

MaximeBaudette avatar MaximeBaudette commented on August 27, 2024

@janlav
Yes and no.
I consider that the test example at the installation is working. I'd prefer if the simulink remained hidden (@tinrabuzin did you fix that or not?).
I intended to leave the issue open so we can discuss whether we need that test or not.

from rapid.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.