Need a help

[alturkovic]

Need a help

[alturkovic]

I am not sure I can help with the current context you provided. The distributed-lock-example uses spring-web and distributed-lock libraries without any issues I am aware of.

How does your Lock implementation with Redisson look like?
Did you import DistributedLockConfiguration using EnableDistributedLock or with your own alias?

It would be best if you could create a minimal project replicating the issue and posting a link to it here.

[selwynshen]

OK, I'll create a demo project and post to you a little while.

[selwynshen]

Sorry that it took me some time to commit my code here in China.
Here is the link of my demo: dl-demo

[selwynshen]

By the way, distributed-lock-example is OK because it uses @EnableDistributedLock which can ensure spring mvc started first and then distributed-lock configuration be loaded.

[alturkovic]

Sorry for the late response.

There seems to be an issue with the ordering of bean creation for ConversionService.

Adding a custom bean in the dl-example projects helps resolve this using:

@Configuration
public class ConversionServiceConfiguration {

    @Bean
    public ConversionService conversionService() {
        return new GenericConversionService();
    }
}

I might need to add @AutoConfigureAfter(WebMvcAutoConfiguration.class) but I need to test that, I am currently a bit short on time unfortunately so I don't know when I will get the chance.

[selwynshen]

Thx a lot. I can achieve it myself.

[selwynshen]

Seems that I've tried @AutoConfigureAfter(WebMvcAutoConfiguration.class) several days before, but still failed. I'll confirm it next weekdays.

[alturkovic]

Sorry, I meant I should include it in distributed-lock-core so you don't have to :)

[selwynshen]

I found that if @ConditionalOnMissingBean annotation wasn't defined on ConversionService bean, then it works. Seems that if webmvc is integrated, then it fails because of the injection of mvcConversionService.

I've created a new branch webmvc for my demo project dl-demo. It worked OK since i defined a specific conversionService bean and injected to SpelKeyGenerator.

Thanks a lot for your help.

[alturkovic]

But what about others who do not use webmvc? The library should provide a default ConversionService itself. The problem is in the DistributedLockConfiguration class, I'll see if I get some time for the weekend to fix and test it.

[selwynshen]

You're right. But the problem is if other ConversionService bean defined, then distributed-lock do not work well.

When we use both spring-boot-web and consul, there even will be 2 ConversionService bean.

I've rewrited DistributedLockConfiguration class. Here is my code snippet. Hope for your suggestions.

@Bean("conversionService")
@ConditionalOnMissingBean(name = "conversionService")
public ConversionService conversionService() {
    return new DefaultConversionService();
}

@Bean("keyGenerator")
@ConditionalOnMissingBean(name = "keyGenerator")
@ConditionalOnBean(ConversionService.class)
public KeyGenerator keyGenerator(@Qualifier("conversionService") final ConversionService conversionService) {
    return new StringKeyGenerator(conversionService);
}

[alturkovic]

Sorry for the late response again. I released a new version (1.4.2) which should resolve your issue. Please, let me know.

[selwynshen]

Thanks very much. Since I used Spring Boot 2.3.7.Release, I won't integrate 1.4.2 to my project, but your resolution is pretty good. I've just rewrited a new configuration class to replace the old one and it works well.