Giter Site home page Giter Site logo

Comments (4)

erikdarlingdata avatar erikdarlingdata commented on August 24, 2024

Hi Gene,

The whole point of the empty catch block is to discard any errors like the one you're seeing:

This throw an error:
DBCC INPUTBUFFER(32767);

But this doesn't:

BEGIN TRY
    DBCC INPUTBUFFER(32767);
END TRY;
BEGIN CATCH
END CATCH;

So it seems odd that it would still bubble up at all. Are you sure you've got this tracked down correctly?

Thanks!

from sp_whoisactive.

genetsmartx avatar genetsmartx commented on August 24, 2024

Hey Erik,
Thanks for the explanation on the CATCH. I get it. Most of the time the call works to log to the table. During the early morning hours we go through some heavy data loading and monitor for thread pool, disk latency etc.

But at the time of some of the failures/errors, we were sitting pretty. Batch requests down. Memory and CPU at baseline.

The only thing that would cause this error is the INPUTBUFFER call. Not sure why it surfaces but that seems like the cause inside sp_WhoIsActive.

We run it every 20 seconds so perhaps the DELETE is running when the next call starts. But the job should finish the INSERT and the DELETE and end solidly. Then the new iteration should start.

I am willing to take any suggestions to "track it down correctly"

I think maybe wrapping the call to log it in a transaction might help.

from sp_whoisactive.

erikdarlingdata avatar erikdarlingdata commented on August 24, 2024

Hi Gene,

Sorry for over-explaining. You seemed surprised by the empty catch block, so I figured I'd throw it out there.

This is a tough one to take on, because a lot of issues that get reported as bugs here come down to a variety of local factors that are impossible to reproduce outside of a particular user environment/setup.

If you come up with a code fix on your end that solves the problem, you can submit a PR for review. I don't have the bandwidth to either try to reproduce the issue, or make shot-in-the-dark code changes and await feedback.

Thanks,
Erik

from sp_whoisactive.

genetsmartx avatar genetsmartx commented on August 24, 2024

Yes I was indeed surprised. Thank you for that Erik. I understand completely. Thank you. I will see if I can solve it. Will submit a PR if I find an answer. Thank you.

from sp_whoisactive.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.