Giter Site home page Giter Site logo

Support for VRV.co? about piper HOT 6 CLOSED

amarcu5 avatar amarcu5 commented on May 24, 2024
Support for VRV.co?

from piper.

Comments (6)

amarcu5 avatar amarcu5 commented on May 24, 2024 1

Thanks for the feature request. VRV (with experimental captions) is now supported on the develop branch b54770b

from piper.

katzenbaer avatar katzenbaer commented on May 24, 2024 1

Thanks for the update. Your observation was correct, and the issue has been fixed after a restart and reinstall of the extension.

from piper.

katzenbaer avatar katzenbaer commented on May 24, 2024

Hey @amarcu5 , I'm having an issue with the develop build where the captions don't update if the VRV.co tab is not focused.

Reproduction Steps

  1. Open a video on VRV.co.
  2. Go into PIP.
  3. Switch to another tab on Safari.
  4. Notice that the captions are frozen/do not appear
  5. Focus the VRV.co tab.
  6. Notice that the captions work properly again.

from piper.

amarcu5 avatar amarcu5 commented on May 24, 2024

Appreciate the detailed reproduction steps. Now fixed on the develop branch 4ebaab2

from piper.

katzenbaer avatar katzenbaer commented on May 24, 2024

Hi @amarcu5, are the binaries always up to date at https://rawgit.com/amarcu5/PiPer/develop/out/PiPer.safariextz? I removed my existing extension and installed the one available at that URL, but I am still having the issue.

from piper.

amarcu5 avatar amarcu5 commented on May 24, 2024

Strange, the binaries are always up-to-date and it works fine for me. I've noticed Safari is a little aggressive at caching old versions of an extension; I suggest uninstalling the extension from settings, quitting safari, and then re-opening Safari/installing the new version.

from piper.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.