Giter Site home page Giter Site logo

Comments (7)

ebkalderon avatar ebkalderon commented on July 3, 2024

It seems that splitting the engine into separate sub-crates causes issues with unit testing (see the annotation in pull request #15). Currently, the unit tests are preserved as integration-style tests, but this is not idiomatic Rust practice. If anyone has better ideas on the reorganization process, please discuss them here.

from amethyst.

kvark avatar kvark commented on July 3, 2024

We don't have this problem in GFX. Perhaps, you could follow the same structure?

We have most of the crates inside the same repository, and they are in sub-folders (src/core, src/render, src/backend/gl, etc). Each has its own tests. Then there is a "meta" crate, which is just an empty src/lib.rs, it depends on all the sub-crates via Cargo.toml. Thus, calling cargo build builds everything, calling cargo test tests everything. This meta crate doesn't need to be uploaded to crates.io, it's just for developer convenience.

Edit: pending confirmation that our local tests are indeed called...

from amethyst.

ebkalderon avatar ebkalderon commented on July 3, 2024

@kvark After playing around with my local copy of the repository, I can conclude that while cargo build does indeed build everything and cargo clean does clean everything, this behavior does not appear to extend to cargo test. Can you confirm?

from amethyst.

ebkalderon avatar ebkalderon commented on July 3, 2024

A general question: should the amethyst_engine crate exist? If not, should its functionality be put in the top-level amethyst crate?

from amethyst.

kvark avatar kvark commented on July 3, 2024

Isn't Amethyst a game engine? What is supposed to be in amethyst_engine then?

from amethyst.

ebkalderon avatar ebkalderon commented on July 3, 2024

It is indeed! I was wondering whether the code in amethyst_engine should be moved to the top-level amethyst crate, or if it should stay in its own crate.

from amethyst.

ebkalderon avatar ebkalderon commented on July 3, 2024

Engine restructuring has been completed with commit 449dd3a, so I'm closing this issue.

As of now, amethyst/tools#4 remains open. The public 0.2.0 release will occur when that issue is resolved.

from amethyst.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.