Comments (7)
It seems that splitting the engine into separate sub-crates causes issues with unit testing (see the annotation in pull request #15). Currently, the unit tests are preserved as integration-style tests, but this is not idiomatic Rust practice. If anyone has better ideas on the reorganization process, please discuss them here.
from amethyst.
We don't have this problem in GFX. Perhaps, you could follow the same structure?
We have most of the crates inside the same repository, and they are in sub-folders (src/core
, src/render
, src/backend/gl
, etc). Each has its own tests. Then there is a "meta" crate, which is just an empty src/lib.rs
, it depends on all the sub-crates via Cargo.toml. Thus, calling cargo build
builds everything, calling cargo test
tests everything. This meta crate doesn't need to be uploaded to crates.io
, it's just for developer convenience.
Edit: pending confirmation that our local tests are indeed called...
from amethyst.
@kvark After playing around with my local copy of the repository, I can conclude that while cargo build
does indeed build everything and cargo clean
does clean everything, this behavior does not appear to extend to cargo test
. Can you confirm?
from amethyst.
A general question: should the amethyst_engine
crate exist? If not, should its functionality be put in the top-level amethyst
crate?
from amethyst.
Isn't Amethyst a game engine? What is supposed to be in amethyst_engine
then?
from amethyst.
It is indeed! I was wondering whether the code in amethyst_engine
should be moved to the top-level amethyst
crate, or if it should stay in its own crate.
from amethyst.
Engine restructuring has been completed with commit 449dd3a, so I'm closing this issue.
As of now, amethyst/tools#4 remains open. The public 0.2.0 release will occur when that issue is resolved.
from amethyst.
Related Issues (20)
- Pong game breaks when using Airpods Pros HOT 5
- Derive proc_macros unnecessarily require the user to import apparently arbitrary types HOT 1
- RenderingBundle has undocumented dependency when used with ApplicationBuilder HOT 2
- RenderToWindow::from_config_path - Parse Errors include filename that couldn't be parsed HOT 2
- Include brew dependencies for MacOS HOT 1
- update amethyst_rendy to use rendy 0.5.1 HOT 1
- Reduce friction to use register_asset_type! macro HOT 1
- Allow use of legion system macros without needing to manually add legion crate HOT 1
- Add example how to add thread local bundle / system with object which can not be send between threads HOT 3
- Most Examples Are breaking, With missing imports HOT 1
- supported platforms? HOT 1
- Examples fail to run second time with error: failed to load manifest for workspace member .assets_db HOT 1
- Custom pipeline properties for rendering (3D-related)
- [Question] is there a way to download all of amethyst for convenient offline use
- the focus screen functionality does not work at all HOT 9
- Amethyst rendy is broken, the build is broken and has been broken for more than a year HOT 4
- Amethyst Roadmaps not updated to reflect project discontinuation
- amethyst was deprecated? if yes, why? HOT 3
- Make tiled windows fullscreen
- Wide layout not resizing with new windows. Requires relaunching.
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from amethyst.