Adding a component trigger `changed` filter for other components

[amethyst]

Adding a component trigger `changed` filter for other components

[cart]

I'm not a legion expert but I have a theory: the archetype changed when you added Bar, which resulted in a move of the entity's components, which triggered a "changed" event for Foo?

[TomGillen]

Cart is right. When you add a component to an entity, it internally moves the entity into a new chunk, which will cause all components to be seen as changed. Composition changes are essentially removing the entity and then inserting a new one with the same Entity ID.

[cart]

Its good that we understand why its happening, but is the behavior of this event desirable? Is there a way to make the event behave the way most people would expect it to?

It makes the event less useful for things like "I only want to update the transform hierarchy when the position component changes".

[cart]

In that case, the value of the component hasnt changed. Only the internal legion representation of the value. From the perspective of the public interface presented nothing has changed.

[IcanDivideBy0]

Yes, I've come to the same conclusion that archetype change is in cause. Specifically, changed filter checks for the version number of the component slice (not the component).

Some possibilities i see:

• adding the PartialEq to Component trait would allow the filter to check for equality in case version number changed nevermind, this would require to store store previous components data as well to compare against
• refactoring ComponentResourceSet to use multiple versions (per component), in such case ComponentResourceSet::data_slice_mut<T> should be in charge of incrementing versions numbers and ComponentResourceSet::data_raw_mut may not be public anymore. This will add some overhead but will provide the "correct" behavior IMO
• renaming filter to may_have_changed ?

let me know if you have any other ideas

I'm not really familiar with legion nor the archetype storage strategy, if you have some documents or articles around these subject, it might worth putting a link into the readme, took me a lot of time getting my head around the basic principle.

[IcanDivideBy0]

Any news / feedback on this ?
It seems the changed filter is broken in many ways at the moment, not just in the case of adding a component. Also having a filter for added / deleted components seems essential IMO.
I'd be happy to contribute if you can point me in the right direction @TomGillen

[IcanDivideBy0]

It seems to be fixed now on master, probably in c99326e