Static port for serving files is not good

[amilajack]

Static port for serving files is not good

[amilajack]

I see that the port 9090 has been used as a static port for serving the video, srt

To my knowledge, I believe it only serves .srt files.

Shall I take this issue up and fix it ?

That would be great! I would recommend looking into how create-react-app does this.

[karuppiah7890]

@amilajack I actually checked out the links which are serving the files, in my browser.
Here's a snapshot :

You should check it out yourself. And yeah, I saw the code you linked. Looks pretty neat. I was looking at some similar packages for detecting if a given port is used or not. I guess I will just use detect-port and do it myself after checking about Promises.

By the way, the code you mentioned, it asks users if they want to use another port. But in our case, I think we don't need to ask the user such questions. We can just abstract them from that, and just use the free port provided by detect-port

[amilajack]

My bad. I forgot which port was which:

9090 is for torrents
4000 is for subtitles (vtt) files

[karuppiah7890]

Oh, okay! And yeah, I did search for the port number in the repo in GitHub search box and found a constant port, only after which I reported the issue.

And actually, I saw that for some of the movies, the srt files were also being served at 9090. I don't know which movies they were though. Is that some weird behavior ? I will check those movies again if I can recall and get back.

[amilajack]

And actually, I saw that for some of the movies, the srt files were also being served at 9090

If you have FLAG_SUBTITLES=true, then .srt files should be served. If they're served and the flag is set to false, this is a bug.

[amilajack]

Would be great if you could make a PR to prevent port collision for the subtitle and torrent server.

[karuppiah7890]

Sure! I will do it. I just need some time to get a basic overview of the related code and then I will get started.

[amilajack]

Great! Thanks 🎉

[amilajack]

Fixed this