Comments (18)
No, the issue doesn't persist in the release-0.0.6-alpha
branch
from popcorn-time-desktop.
Here's why the tests are failing:
Expected 300 to be above 400
: This is failing because the torrent provider isnt returning the optimal amount of seeders. Obviously the seeder counts of torrents change over time so testing against this was somewhat unusual but I wanted to assert somehow that we were retrieving an optimal amount of seeders for each provider. For example, if I make a change to a provider, i dont want the seeders to suddenly go from ~400 to 100.Timeout exceeded
: This is failing probably because the endpoint is either blocked or the provider's endpoint is down. This this is one of the most common reasons for test failure.
3, 4. Expected undefined to be a string
: I just noticed this on my build today as well. I made the tests even stricter and fixed the issue causing this 😄
Not able to fetch torrents
So are you not getting any torrents at all or are you talking about how you can't get torrents for a specific provider?
Please lmk if you have any more questions!
from popcorn-time-desktop.
from popcorn-time-desktop.
What errors are you getting in the console?
from popcorn-time-desktop.
That's the problem, I don't get any errors in the developer tools. But just
now I got an error when i tried some totally new movie, and it said said
some "Type error" and said "Can't write to a read only object".
On Oct 8, 2016 10:08 PM, "Amila Welihinda" [email protected] wrote:
What errors are you getting in the console?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#175 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AMNw6FmWT450r4JgYC7oVGXe5Gad73Dvks5qx8cCgaJpZM4KRpp6
.
from popcorn-time-desktop.
I get this :
Movie.js:559
TypeError: Cannot assign to read only property '0' of object '[object Array]'
at Array.sort (native)
at sortTorrentsBySeeders (webpack:///./app/api/torrents/BaseTorrentProvider.js?:278:19)
at selectTorrents (webpack:///./app/api/torrents/TorrentAdapter.js?:272:71)
at _callee$ (webpack:///./app/api/torrents/TorrentAdapter.js?:116:28)
at tryCatch (webpack:///.//regenerator-runtime/runtime.js?:62:40)/regenerator-runtime/runtime.js?:62:40)
at GeneratorFunctionPrototype.invoke as _invoke
at GeneratorFunctionPrototype.prototype.(anonymous function) as next
at tryCatch (webpack:///./
at GeneratorFunctionPrototype.invoke as _invoke
at GeneratorFunctionPrototype.prototype.(anonymous function) as next
at step (webpack:///.//babel-runtime/helpers/asyncToGenerator.js?:17:30)/babel-runtime/helpers/asyncToGenerator.js?:28:20)
at eval (webpack:///./
Image :
from popcorn-time-desktop.
Hmm. That's weird. Are you sure you have the most recent changes of ui-design-implementation
branch?
from popcorn-time-desktop.
Oh wait you aren't on that branch at all. Here's the steps for building in case you missed them. I can't guarantee any other branch works properly. The only one I can guarantee is the ui-design-implementation
branch because that's what I'm working on now. That branch will be merged into release-0.0.6-alpha
and that will be merged into master
. This will all happen (hopefully) in the course of 2-3 months.
from popcorn-time-desktop.
Update: I've just merged the ui-design-implementation
branch into the release-0.0.6-alpha
branch. You don't have to switch branches but you should if you want to receive updates in the future.
Here's the overview of how branches are merged
release-x.x.x-alpha => dev-master => master
from popcorn-time-desktop.
@amilajack I am sorry for bothering you so much for this issue.
And yeah, I get it that I should use the ui-design-implementation
branch to get new updates. But I am on the master
branch, which I believe is stable, and I have packaged the App using npm run package
in the master
branch and everything works fine in the packaged App, including the fetching of torrents and showing the movie. But when I use the development build using npm run dev
on the master
branch, I am not able to fetch torrents and not able to see any movie. Why is this so ? It's absurd.
And if I want to make a pull request, should it be pointed to the master
branch or dev-master
or release-x.x.x-alpha
or what ?
from popcorn-time-desktop.
And if I want to make a pull request, should it be pointed to the master branch or dev-master or release-x.x.x-alpha or what ?
All PR's should be made to release-x.x.x-alpha
But I am on the master branch, which I believe is stable
Unfortunately it isnt. Both travis and appveyor builds are failing on it:
Currently release-0.0.6-alpha
is the most stable.
from popcorn-time-desktop.
Damn. Then how is my packaged App alone working ? It was packaged using master
branch code
from popcorn-time-desktop.
And yeah, I will get the release-x.x.x-alpha
code. And can we please make all this clear in the CONTRIBUTE.md ? Helps newbies like me, who didn't notice the build badges. And it will also help everyone to know which branch to contribute to.
from popcorn-time-desktop.
Webpack has separate build steps for production and development environments. dev env is significantly slower and has much more deps. production webpack config strips everything out and optimizes js as much as it can.
from popcorn-time-desktop.
Oh, okay. Thanks for the info. I guess I will just use the release-x.x.x-alpha
branch
from popcorn-time-desktop.
And can we please make all this clear in the CONTRIBUTE.md
This is definitely a good idea. This would clear up so much unnecessary confusion. Sorry about that! I have a number of weird conventions for this project but I think they'll pay off in the end. The reason why there's a release-x.x.x-alpha
branch is so that all the members of the team know what is the latest release. Also if we want to patch an old release, we can do that. Also if you haven't seen it yet, here's the roadmap.
from popcorn-time-desktop.
Just added a PR section to the CONTRIBUTING.md. Thanks for the suggestion!
from popcorn-time-desktop.
Let me know if the issue persists in that branch. If it does then I'll reopen the issue
from popcorn-time-desktop.
Related Issues (20)
- publish to launchpad
- NavBar should be sticky
- tv show torrents broken HOT 2
- tv shows runtime broken HOT 1
- re-enable e2e tests
- migrate to typescript HOT 1
- replace mdns dependency with pure JS implementation
- Virtualize CardGrid for better performance
- Migrate to hooks
- Migrate to ionicons@5
- Default movie player contains blank space
- Project status query HOT 5
- Looking for contributors?
- Action Required: Fix Renovate Configuration
- Dependency Dashboard
- Yarn fails on M1 Macbook Air with BigSur 11.6 HOT 1
- [Security] Workflow publish.yml is using vulnerable action actions/checkout
- [Security] Workflow test.yml is using vulnerable action actions/checkout
- Popcorntime for Android
- Seeding
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from popcorn-time-desktop.