Threshold decryption seems to not actually work?

[amiller]

Threshold decryption seems to not actually work?

[amiller]

Thanks for this report. From a quick glance, it does look at least like verify_share is not called from anything in the repo right now (dev branch).

For now I added a negative test case, and added verification of each share in combine_shares.
b28b835

It would be more efficient to optimistically compute the decryption and then check it, only verifying each share if the overall decryption fails. #11 The right thing to do for now seems to be to err on the side of caution and reduce it to a performance issue.

[Vagabond]

I think the breakage is more fundamental than that, I had to rewrite decrypt_share, combine_shares and verify share quite drastically to get them to pass my property tests. The python code varied drastically from the paper.

[sbellem]

This issue was moved to initc3/HoneyBadgerBFT-Python#46

/cc @amiller @Vagabond