NeovimSSHProvider:get_user_selection never exits

[amitds1997]

NeovimSSHProvider:get_user_selection never exits

[NilujePerchut]

Thank you very much for your answer (and this useful plugin !).

Here follows a screencast of the my actions.
I am connecting to osdegirouette host using an entry in my .ssh/config.

screencast.webm

As you can see, as soon as I press enter after entering "2" to select nvim v0.9.1, RemoteStart get stuck.

After a few debugging I can tell that the command is stuck in the NeovimSSHProvider:get_user_selection function and never reach the end of the function. I can see the callback be called. But nothing more. As I said in my first post it takes the coroutine.yield() statement and never reach the end of the get_user_selection function.

I hope this will help.

I wanted to attach the log file but I can't find it.

Thanks in advance for your help.

[NilujePerchut]

It's working great now.
Thank you very much !

[amitds1997]

Thanks for reporting the issue! NeovimSSHProvider:get_user_selection uses vim.ui.select which operates async so the callback should resume the coroutine once a selection is made and the coroutine remains paused until then.

Could you please provide a screen cast showing the issue you are facing? I could not gather the exact scenario that you are running into. While doing that, could you also gather the debug logs? You can follow this comment about how to generate those logs.

[amitds1997]

Here follows a screencast of the my actions. I am connecting to osdegirouette host using an entry in my .ssh/config.
screencast.webm

As you can see, as soon as I press enter after entering "2" to select nvim v0.9.1, RemoteStart get stuck.

After a few debugging I can tell that the command is stuck in the NeovimSSHProvider:get_user_selection function and never reach the end of the function. I can see the callback be called. But nothing more. As I said in my first post it takes the coroutine.yield() statement and never reach the end of the get_user_selection function.

Thanks for the screencast. The issue was indeed in the get_user_selection method. The default implemenatation of vim.ui.select is synchronous (it calls :inputlist). The previous implementation assumed that the implementation would be asynchronous (something that is true with plugins like dressing.nvim which override the interface).

The issue should be fixed by fb2c301 and you can check out the master branch to test it out. Do let me know if you still see this issue.