Trouble with simple includes

[amperka]

Trouble with simple includes

[rei-vilo]

Same problem for me: library not found.

I tried two cases:
1• the library is in the sketchbook/libraries user folder,
2• the library is in the project's src sub-folder.

Both return an error.

[zenoamaro]

It seems that ino fails when parsing the dependencies.d file, when multiple dependencies are given in a single line:

sketch.o: .build/src/sketch.cpp \
    /Applications/Arduino.app/.../arduino/Arduino.h \
    /Applications/Arduino.app/.../arduino/binary.h \
    ...
    /Applications/Arduino.app/.../arduino/new.h \
    /Applications/Arduino.app/.../standard/pins_arduino.h \
    lib/SSegs/SSegs.h lib/Framebuffer/Framebuffer.h lib/Metro/Metro.h

The problem is that match only matches the first occurence. Without changing the REs, the fix is as simple as this:

in commands/build.py:173

used_libs = set()
with open(output_filepath) as f:
    for line in f:
        matches = local_re.findall(line) or dist_re.findall(line)
        for match in matches:
            used_libs.add(match[0])

While using findall is not as nice as the regular match (as we lose references to named groups), it works. I'll provide a patch later.

[fabiankr]

Did anyone get includes to work correctly? The pull request doesn't work for me.

[zenoamaro]

Here is a link to a test sketch that builds: test-sketch.zip

This is the sketch file tree:

test-sketch/
    lib/
        TestLib/
            TestLib.h
            TestLib.cpp
    src/
        sketch.ino

TestLib is simply imported as #include <TestLib.h>, as it will automatically be in the path.

[fabiankr]

Okay, that works fine. But what about something like this:

test-sketch/
    lib/
    src/
        sketch.ino
        defines.h

There's no way to include defines.h in sketch.ino but this build fine using the official IDE. If you can help me to get it working, it'd be awesome.

[zenoamaro]

I'm sorry, I misunderstood your problem, I thought it was the same as mine.

Well, I know the official Arduino IDE concatenates all the tabs open in the project. Perhaps ino only concatenates multiple .ino files? I'll make some tests.

Regarding #including per se: it seems that the automagic build step moves sources around. If so, then a #define "lib.h" would search for the file in the wrong directory. I remember having witnessed this during my initial troubles with imports.

[rei-vilo]

I'm referring to the user-developped libraries, placed in the sketchbook/libraries folder.

The sketchbook directory is declared in the Preferences pane of the Arduino IDE.

The sub-folder called Libraries is included in the building process by default.

[fabiankr]

@rei-vilo: You need to move the user-developed libraries to the lib subfolder.
@zenojevski: gcc searches for the headers in the current directory, but I don't understand the MakeFile.jinja code well enough to make it work correctly. Somewhere the header files need to be moved to the working directory of gcc...

[fabiankr]

If you write #include "../../src/Defines.h" it works without problems. That means the .h files only need to be moved in the .build/src/ directory like the other files.
I don't know where ino does the copying of the files, but I will try to solve the issue now.

[fabiankr]

There is now a working fork with simple includes: #20

[zenoamaro]

@fabiankr Here is a less invasive "fix" that allows importing from "src/" by adding it to the dependency scan. I've also added a few fixes and a test sketch a couple commits later.

If you could let me know if it works for your situation it'd be great.

[fabiankr]

It works like a charm. I like your solution more, thanks. :)

[zenoamaro]

@fabiankr Thanks!