Giter Site home page Giter Site logo

Comments (2)

mmalfertheiner avatar mmalfertheiner commented on June 1, 2024 2

I had to change the core of redux-query as well, in order that I never have to make toJS() on the redux store. I saw your proposal as well, but in that case you translate the store to JS each time you pass it to the reducer. This causes new references for every object in the redux-store, which has the effect that you can not make shallow comparisons in the components anymore. Let me try to explain it with an example:

I have the following structure:

"entities": { "users": [ { "id": 1, "name": "Bart" }, { "id": 2, "name": "Lisa" }, { "id": 3, "name": "Maggie" }, ] }

If you would change now only a single user of the list, than you want to have a new reference for entities, users and the user that you changed, but not for the other users.

The changes I made are not compatible with the original library, thats why I made a new package for it. The functionality stays the same and my goal is to merge any changes to redux-query also into the redux-query-immutable project.

from redux-query.

RohovDmytro avatar RohovDmytro commented on June 1, 2024

Nice!

Couple of questions. Why not pull request? What problem did you solve? (I'm using immutable js and redux-query just fine)

from redux-query.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.