Giter Site home page Giter Site logo

Comments (4)

squaremo avatar squaremo commented on May 20, 2024

It's not disabled at present. I note that other RabbitMQ clients tend to switch it off (e.g., https://github.com/rabbitmq/rabbitmq-java-client/blob/master/src/com/rabbitmq/client/ConnectionFactory.java#L492)

So, I think I shall

  1. Switch it off in sockets; and,
  2. Provide an option (to createConnection etc.) to keep it on

from amqplib.

squaremo avatar squaremo commented on May 20, 2024

OK, fixed in 854b175.

It's not clear that disabling Nagle leads to a performance boost, so I've left it enabled by default. Disable it by providing {noDelay: true} in connection options; e.g.,

var ok = require('amqplib').connect('amqp://localhost', {noDelay: true});

from amqplib.

umar-frag avatar umar-frag commented on May 20, 2024

That was quick. Thanks a lot!

from amqplib.

squaremo avatar squaremo commented on May 20, 2024

No problem. It might take a bit longer to make it into a release, since I tend to wait until there's a few enhancements, or critical fixes, before I roll releases.

from amqplib.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.