Clarify the "Argument must be a string" error?

[amqp-node]

Clarify the "Argument must be a string" error?

[michaelklishin]

encodeBasicPublish suggests it was a published message, so I guess it's routing key or one of the headers that's not a string (header values can be anything, though).

[squaremo]

Yes, it's the routing key being undefined or null I think.

I actually go to a bit of trouble to generate code that detects invalid values and raise artisinal errors with the field name and a little certificate of ownership and so on -- but the code generating code has a bug! Which means this makes it past those checks, then fails on some Node.JS core library with a bland, off-the-shelf error message.

For the minute, make sure you're at least passing an empty string in as the routingKey argument to publish.

[squaremo]

OK, fixed the bug in the code generation, and hand-turned some better error messages.

Just to be clear, it is supposed to be fine to pass undefined for either of the routingKey and exchange arguments to #publish, since they both have a default of "" in the protocol. Supplying null for either will result in an error though. In other words, undefined means "I don't have a value for you", and null means "Who's Tony Hoare?".

[mxriverlynn]

undefined vs null: make sense. thanks, yo! :)

[squaremo]

Derick, would you give this and #49 a sanity check using master branch? I need to write some tests, for this one especially, and it would be good to have your confirmation too.