Alternate exchange not showing correctly in management plugin

[amqp-node]

Alternate exchange not showing correctly in management plugin

[michaelklishin]

Not only they don't display the tag, they also don't work as they should ;)

Thanks for reporting this!

[dizzus]

You welcome. Btw, I think the similar problems may occur with other exchange/queue arguments. For example: deadLetterExchange - I have a huge suspicion it's not gonna work as expected too. Why not simply pass user-supplied 'arguments' object as is?

[michaelklishin]

I'm not familiar enough with the codebase to tell but perhaps the idea is to mass-convert keys right before sending the method? I agree that arguments should probably be accepted as is. This way all new arguments-based features can be used without client modifications.

[dizzus]

Absolutely. Arguments are supposed to be used for vendor-specific extensions, so they should be left alone and passed as is.

[squaremo]

Yep, that's me tricking myself by trying to be too clever.

Why not leave these things in an arguments table? Mainly because I wanted a consistent API which included RabbitMQ extensions, and explaining why some things go in options and some things go in a field called arguments in options is awkward.

[michaelklishin]

@squaremo so, how do you want it to work?

[squaremo]

@michaelklishin Extensions get aliases in options (as it is now, but working properly[1]). arguments is still one of the options where it appears in the protocol.

One snag is what to do if something appears both in options and options.arguments, but I think the main thing is to be consistent.

I'll fix up [1] this afternoon.

[squaremo]

Fixed in 3749c66 I believe.

One snag is what to do if something appears both in options and options.arguments

Anything supplied in the arguments field is superseded by a value passed as an option (by being shadowed; I no longer mutate the value passed in as arguments, which was naughty)