Comments (3)
Thanks @Sprachprofi. This seems like a bug — Gibbon should throw a proper error with whatever response the API provides. Unfortunately, I am traveling for work the next week and I don’t expect I’ll have time to investigate this in the meantime. I can investigate once I get back from my trip (next weekend), or I’m happy to accept a patch if you are interested in taking a look (no expectation of that on my end, to be clear).
The expected behavior is to throw a gibbon typed error that wraps whatever the API returns, but I do not want to define an error type/class for every API error.
Taking a quick look at the source, I suspect the bug is on line 114 of api_request.rb
gibbon/lib/gibbon/api_request.rb
Line 114 in 5ce47aa
from gibbon.
Hey, thanks for the quick response. That does look like it. Fwiw, I upgraded to the latest version of Gibbon and that fixed it, so there may not be a need to do anything. People who will continue to be affected are those forced to use Gibbon 3.2.x, for example because of being locked into an earlier Ruby version. Those would need to figure out which is the last version of Faraday that still uses Faraday::Error::ClientError rather than the newer Faraday::ClientError and then manually lock to that one, because Gibbon 3.2.x does not have an upper bound on Faraday version.
from gibbon.
from gibbon.
Related Issues (20)
- pass the content in campaign
- Cannot set faraday_adapter globally HOT 3
- Changelog updates for 3.3.2 HOT 2
- NameError: uninitialized constant Faraday::Error::ClientError HOT 3
- Rescued errors come back with all nil values? HOT 8
- Got error saying api_key not found HOT 1
- gibbon report issue
- How to send campaign emails to some specific users? HOT 1
- How to delete a member from a list? HOT 5
- How to add member in the segment of a list ?
- Faraday 1.x.x compability HOT 2
- Deprecated warning on Faraday::Connection#basic_auth HOT 4
- 3.4.1 Causes 401: API Key Invalid HOT 7
- updating members in batching does not work HOT 1
- Gibbon doesn't work with Faraday 2.x HOT 4
- How to unsubscribe email that is bounced, pending, or archived? HOT 3
- v3.4.4 security patch for v3.4.0? HOT 1
- API Export 1.0 and API 2.0 will be retired on June 5, 2023 HOT 11
- Updating from 1.x: How to replace .lists.merge_var_add? HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from gibbon.