Giter Site home page Giter Site logo

Comments (10)

anacrolix avatar anacrolix commented on July 17, 2024 2

@probonopd Thanks for finding this. I've submitted an issue to rclone, hopefully they are interesting in contributing their improvements on this. As for plugging it in, it would go alongside the code that was copied there in the first place 😆 .

from dms.

anacrolix avatar anacrolix commented on July 17, 2024

@probonopd thanks for the pcap! It looks like dms returns HTTP 500 errors for the SOAPACTION "urn:schemas-upnp-org:service:ContentDirectory:1#X_GetFeatureList". I expect there could be a more appropriate error to return for this unsupported request, that may have the Samsung handle the results better. It may be aborting whatever it was attempting, rather than trying to proceed with an unsupported action. The other choice would be to implement the action.

I won't look into that just now, I'm not active on this project at the moment.

from dms.

probonopd avatar probonopd commented on July 17, 2024

Thanks @anacrolix for your analysis. Searching for X_GetFeatureList in Golang code, I found the rclone project which, among many other features, can also serve directories on the local filesystem to DLNA devices. I can confirm that the Samsung TV can play the same video using rclone indeed.

Looking at the rclone code, the solution may be rather easy:

https://github.com/rclone/rclone/blob/66e08e0cc8972000d84a61f262286f5644d9fdee/cmd/serve/dlna/cds.go#L325-L341

Where would this need to be plugged into the dms code?

from dms.

anacrolix avatar anacrolix commented on July 17, 2024

@probonopd can you try #86?

from dms.

claes avatar claes commented on July 17, 2024

I have a Samsung UE46D6300 (so similar but not identical), and I can confirm this problem with v.1.6.0

from dms.

anacrolix avatar anacrolix commented on July 17, 2024

I have a Samsung UE46D6300 (so similar but not identical), and I can confirm this problem with v.1.6.0

@claes Did you try #86 ?

from dms.

claes avatar claes commented on July 17, 2024

@anacrolix No, but since it was merged I assumed it was part of 1.6.0, but perhaps it isn't?

from dms.

anacrolix avatar anacrolix commented on July 17, 2024

You are quite right. I'll leave the issue open.

from dms.

WithoutPants avatar WithoutPants commented on July 17, 2024

Stash recently had a PR (stashapp/stash#4784) submitted to fix what appears to be a related issue (stashapp/stash#1768).

The change was to add the following headers when streaming a file:

  • transferMode.dlna.org set to Streaming
  • contentFeatures.dlna.org set to DLNA.ORG_OP=01;DLNA.ORG_CI=0;DLNA.ORG_FLAGS=01500000000000000000000000000000

I can see that the former is already included upstream. Having had a look at

func (cf ContentFeatures) String() (ret string) {
it looks like the latter already corresponds to a ContentFeatures instance with SupportTimeSeek = false, SupportRange = true, and Transcoded = false. The only other difference is that the DLNA.ORG_FLAGS value starts with 015 instead of 017.

I don't have a Samsung TV to test with, nor do I know the DLNA protocol well enough to be confident that this change would be the solution to this original problem. A request was made to contribute the fix upstream, but as far as I can tell there doesn't appear to be anything useful to contribute.

from dms.

anacrolix avatar anacrolix commented on July 17, 2024

@WithoutPants that's really helpful, appreciated.

from dms.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.